-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use privacy-preserving webxdc addresses #6237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d one cannot guess hash from the set of known addresses (which may be small)
r10s
force-pushed
the
webxdc-addr-privacy
branch
from
November 20, 2024 19:30
fcc1d4b
to
6d327ac
Compare
r10s
commented
Nov 20, 2024
r10s
changed the title
use privacy-preserving addresses
feat: use privacy-preserving webxdc addresses
Nov 20, 2024
Here is an answer to a similar question regarding security of hashing a secret key: |
@link2xt i changed generation to use fingerprint as discussed |
link2xt
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds the address to be used by the UI for
window.webxdc.selfAddr
to webxdc-info. UIs need to be changed accordingly and must not use configured_addr any longer.the address is created by sha256(private-key + rfc724_mid) , which results in different addresses for each webxdc, without the option to find out the real address of the user.
this also returns the same address for a multi-device-setup - sending totally random self address around might be an alternative, however would require connectivity (both devices may be offline on first start).
for existing app, after the change, there will be a new user, resulting eg. in a new highscore, otherwise, things should be mostly fine. this assumption is also important as we might change the thing another time when it comes to multi-transport.
ftr, addresses look like
0f187e3f420748b03e3da76543e9a84ecff822687ce7e94f250c04c7c50398bc
nowwhen this is merged, we need to adapt #6230 and file issues for all UI to use
info.selfAddr
closes #6216