Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove imap_tools from dependencies #6238

Merged
merged 2 commits into from
Nov 23, 2024
Merged

remove imap_tools from dependencies #6238

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aac7c6
remove imap_tools from dependencies
adbenitez Nov 20, 2024
91d2442
add direct_imap fixture
adbenitez Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deltachat-rpc-client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ $ pip install .
## Testing

1. Build `deltachat-rpc-server` with `cargo build -p deltachat-rpc-server`.
2. Run `CHATMAIL_DOMAIN=nine.testrun.org PATH="../target/debug:$PATH" tox`.
2. Install tox `pip install -U tox`
3. Run `CHATMAIL_DOMAIN=nine.testrun.org PATH="../target/debug:$PATH" tox`.

Additional arguments to `tox` are passed to pytest, e.g. `tox -- -s` does not capture test output.

Expand Down
3 changes: 0 additions & 3 deletions deltachat-rpc-client/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ classifiers = [
"Topic :: Communications :: Email"
]
readme = "README.md"
dependencies = [
"imap-tools",
]

[tool.setuptools.package-data]
deltachat_rpc_client = [
Expand Down
2 changes: 1 addition & 1 deletion deltachat-rpc-client/src/deltachat_rpc_client/direct_imap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
)

if TYPE_CHECKING:
from . import Account
from deltachat_rpc_client import Account

FLAGS = b"FLAGS"
FETCH = b"FETCH"
Expand Down
2 changes: 1 addition & 1 deletion deltachat-rpc-client/tests/test_something.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
from unittest.mock import MagicMock

import pytest
from direct_imap import DirectImap
adbenitez marked this conversation as resolved.
Show resolved Hide resolved

from deltachat_rpc_client import Contact, EventType, Message, events
from deltachat_rpc_client.const import DownloadState, MessageState
from deltachat_rpc_client.direct_imap import DirectImap
from deltachat_rpc_client.rpc import JsonRpcError


Expand Down
1 change: 1 addition & 0 deletions deltachat-rpc-client/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ deps =
pytest
pytest-timeout
pytest-xdist
imap-tools

[testenv:lint]
skipsdist = True
Expand Down
Loading