Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use underscores in deltachat-rpc-server source package filename #6254

Merged
merged 1 commit into from
Nov 23, 2024
Merged

build: use underscores in deltachat-rpc-server source package filename #6254

merged 1 commit into from
Nov 23, 2024

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Nov 23, 2024

Closes #6244

@link2xt link2xt requested review from adbenitez, hpk42 and r10s November 23, 2024 21:25
@link2xt
Copy link
Collaborator Author

link2xt commented Nov 23, 2024

It indeed looks wrong at https://pypi.org/project/deltachat-rpc-server/#files that wheels have underscores, but source package has -.

@link2xt link2xt merged commit eed2320 into main Nov 23, 2024
38 checks passed
@link2xt link2xt deleted the link2xt/pep625 branch November 23, 2024 21:49
@link2xt link2xt mentioned this pull request Nov 24, 2024
Merged
@link2xt
Copy link
Collaborator Author

link2xt commented Nov 24, 2024 •
edited
Loading

This actually broke the build of 1.151.0, see #6202 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

@adbenitez adbenitez Awaiting requested review from adbenitez

@hpk42 hpk42 Awaiting requested review from hpk42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make deltachat-rpc-server Python package PEP 625 compatible
2 participants
@link2xt @r10s