two "end search" buttons are unintuitive

[r10s]

when the new (great!) in-chat-search is started, there are two X-buttons to end something.

this alone is a bit confusing, however, the upper X-button also appears to do different things to the end user:

• in global-search, search is ended
• in in-chat-search, search is not ended

in both cases, search field is cleared and focus is removed from search field.

   

to end the in-chat-search, the second button is required. this is also confusing as usually X-buttons shown at higher positions rule the ones at lower positions. seeing the controls for the first time, one would think, that the second X-button just removes a filter or so.

so, in the current UI, one would expect the second button to clear the in-chat-search filter and continue with global search.

however, i do not suggest to make the button a remove-filter-button, instead, i propose to just remove the second X-Button and end all search when pressing the upper one:

• re-entering search is easy - and already know to the user (clicking in the search field or using the menu)
• an explicit shortcut for "clear all" is not that import on desktop - and in the current implementation (focus lost) the gist seems to be more "end search" anyway
• no need to make the second button nicer :)

of course, the upper X-button needs to be shown also when there is no text input in case of in-chat-search then. to be clear: this is only about removal of the second X-button, not about the line showing the chat.

just my 2ct for the in-chat-search :)