-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-second-device strings missing #3178
Comments
i assume, the refactoring milestone is not a prerequisite for changing strings? i'd change these strings as soon as possible, not a blocker and maybe not the reason for a 1.36.1+, but still should be part of it when it is needed because of other things. to be clear: no need to change the whole layout now to match android/ios, just change the hint is already a huuuuge ux improvement (also ios was only about getting some hints in, without much effort - but does not look that bad at the end :) |
the problem is the qr code scanner (which is inside of a dialog), we would need a custom ui there and if we're already doing that then we can do the new scanner as well, it's not that hard. |
…rovements (#3801) * refactor a bit to fix dc login also fixes opening chat after secure join * fix lint * update changelog * fix login with default instance * custom dialog for setup second device (add steps) to address #3178 * fix fmt and changelog entry * add troublehooting button * fix lint * fix import name issue * fix test * change how the add as second device steps are shown and go back to multiclient anchor * fix help not opening for languages that have no localised help closes #3803 * Update CHANGELOG.md Co-authored-by: bjoern <r10s@b44t.com> * Update src/renderer/hooks/useInstantOnboarding.ts Co-authored-by: bjoern <r10s@b44t.com> --------- Co-authored-by: bjoern <r10s@b44t.com>
the idea of the "Add as Second Device" button in the "Welcome" screen is to let ppl not run into problems when setting up a second device.
while the general functionality is there and working nicely, a hint is missing what ppl should do. currently the screen looks like the following:
unless ppl have read instructions somewhere else, they are left completely alone.
as a minimum, we should replace the title and the text below the qr code with
multidevice_receiver_title
resp.multidevice_open_settings_on_other_device
. ftr, is how android/ios look:related: in the subsequent progress dialog, the title string is missing:
that should be
multidevice_receiver_title
as well.The text was updated successfully, but these errors were encountered: