Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer Refactor: Private reply should not recreate draft #3750

Open
Simon-Laux opened this issue Apr 4, 2024 · 0 comments
Open

Composer Refactor: Private reply should not recreate draft #3750

Simon-Laux opened this issue Apr 4, 2024 · 0 comments
Milestone

Comments

@Simon-Laux
Copy link
Member

// retrieve existing draft to append the quotedMessageId
const oldDraft = await BackendRemote.rpc.getDraft(accountId, chatId)
await BackendRemote.rpc.miscSetDraft(
accountId,
chatId,
oldDraft?.text || null,
oldDraft?.file || null,
quotedMessageId,
'Text'
)

we should remember this pace in the code and take over the existing view type, at best we should make a new core/jsonrpc api for "add quoted message to existing draft".

with the composer refactoring this will definitely become incorrect as it recreates the message and so it would delete all status updates of a prepared webxdc message, it should modify the existing draft if it exists and not recreate the draft message with a new message id.
~ #3725 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant