improve jumbomoji logic #3102
Merged
improve jumbomoji logic #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
force-pushed
the
simon/improve-jumbomoji-logic
branch
from
4b77356 to
17d478f
Compare
improve jumbomoji logic (that emoji only messages appear bigger), now works better with emoji that consist out of multiple sub-emojis like composite emojis (👪) and emojis with skin color (🧑🏾). Also now it works even with new emojis that are not in delta chat yet. also removed dependency on `emoji-regex`, because it's now not needed anymore.
Simon-Laux
force-pushed
the
simon/improve-jumbomoji-logic
branch
from
17d478f to
71c9478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve jumbomoji logic (that emoji only messages appear bigger), now works better with emoji that consist out of multiple sub-emojis like composite emojis (👪) and emojis with skin color (🧑🏾).
also removed dependency on
emoji-regex, because it's now not needed anymore.now works even with new emojis that are not in delta chat yet:
