-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreateChat dialog: Trim the input value to fix #3299 #3300
Conversation
Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok just tested it, looks we also need to trim it before giving it to the email validation function
I just remembered for the same reason I trimmed it in there lol |
@Simon-Laux What's the problem with trimming them the first place I did? |
user can not type spaces which feels restricted, say for example you have multiple contacts with the same first name but different surnames and you want to just type it in, then notice that you can not type a space. |
I've updated the hook used for searching for contacts to trim the provided Also, when the user queries a name, all the contacts with that name and the "New contact" item are shown but clicking on the "New contact" button does nothing. It's a bug I suppose? |
This is a trivial solution to fix #3299. I simply trim the value of the
<input>
upon each change.