Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colour of clock icon in ViewProfile #3331

Merged
merged 10 commits into from
Jul 27, 2023
Merged

Conversation

farooqkz
Copy link
Collaborator

Fixes #3329

@farooqkz farooqkz requested a review from Simon-Laux July 26, 2023 14:29
@@ -58,5 +58,17 @@ div.profile-info-container {
&.clickable:hover {
cursor: pointer;
}

& > i.material-icon {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might have other material icons, so maybe better add the bulk of this calls to some class maybe named .material-svg-icon and then also add a class .material-icon-schedule? and do this in the scss file for icons. then we can also reuse the class elsewhere and would just overwrite things like size in viewProfile if even necessary, Basing it on em is a good choice so probably such overwrites are not necessary.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Simon-Laux How is it now?

Comment on lines 64 to 68
height: 1.15em;
width: 1.15em;
-webkit-mask-size: 1.15em;
margin-inline-start: 0.3em;
margin-inline-end: 0.3em;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also put this in the base class as it adapts to the current font size

@@ -58,5 +58,14 @@ div.profile-info-container {
&.clickable:hover {
cursor: pointer;
}

& > i.material-icon-schedule {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the whole class into the icons file so we could potentially reuse the same icon elsewhere easily

@farooqkz farooqkz requested a review from Simon-Laux July 26, 2023 15:23
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works, but the icon is not entered anymore which does not look good:

before:
Bildschirmfoto 2023-07-26 um 20 59 55
after:
Bildschirmfoto 2023-07-26 um 21 00 05

@farooqkz farooqkz requested a review from Simon-Laux July 27, 2023 08:41
farooqkz and others added 2 commits July 27, 2023 17:54
Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
@Simon-Laux Simon-Laux merged commit 2b93e02 into deltachat:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View profile: clock icon for last seen is not clearly visible in dark mode
2 participants