-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colour of clock icon in ViewProfile #3331
Conversation
scss/dialogs/_view_profile.scss
Outdated
@@ -58,5 +58,17 @@ div.profile-info-container { | |||
&.clickable:hover { | |||
cursor: pointer; | |||
} | |||
|
|||
& > i.material-icon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might have other material icons, so maybe better add the bulk of this calls to some class maybe named .material-svg-icon
and then also add a class .material-icon-schedule
? and do this in the scss file for icons. then we can also reuse the class elsewhere and would just overwrite things like size in viewProfile if even necessary, Basing it on em
is a good choice so probably such overwrites are not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Simon-Laux How is it now?
scss/dialogs/_view_profile.scss
Outdated
height: 1.15em; | ||
width: 1.15em; | ||
-webkit-mask-size: 1.15em; | ||
margin-inline-start: 0.3em; | ||
margin-inline-end: 0.3em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can also put this in the base class as it adapts to the current font size
scss/dialogs/_view_profile.scss
Outdated
@@ -58,5 +58,14 @@ div.profile-info-container { | |||
&.clickable:hover { | |||
cursor: pointer; | |||
} | |||
|
|||
& > i.material-icon-schedule { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move the whole class into the icons file so we could potentially reuse the same icon elsewhere easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Simon Laux <Simon-Laux@users.noreply.github.com>
Fixes #3329