Show confirm dialogue when creating new chat after clicking mail address #3469
Conversation
adzialocha
force-pushed
the
confirm-new-chat
branch
from
d5b854e
to
6cc2077
Compare
adzialocha
force-pushed
the
confirm-new-chat
branch
from
6cc2077
to
47ed1c3
Compare
adzialocha
changed the title
There was a problem hiding this comment.
The mailto links of https://github.com/deltachat/interface/blob/master/user-testing/mailto-links.md don't work anymore.
To test either install deltachat from this batch and set as default mailer or easier open the raw md file and copy the full links, then scan qrcode scan from clipboard and also test clicking them from a message
Edit: sorry I probably tested with wrong core.
|
hi, @adzialocha! first of all, welcome aboard and congrats for landing your first prs! in general, thanks a lot for the great pr description and for the nice video, giving ppl a bit outside desktop code a good overview what a pr is about. this is very welcome! |
There was a problem hiding this comment.
Just tested with the core master, works now as expected for me. Sorry for the confusion.
We can merge after you addressed my review comments and we have the new core release with the new jsonrpc api.
BTW: maybe we should have a different error when the chat stuff failed, "mailto parse failed" is rather confusing.
* master: fix window store installation (remove unknown language code from supported languages) Update translations (05.11.2023) remove the `any`, as electron types the `request` parameter already in this callback fix tests fix #3470 remove useless if statement add CHANGELOG entry run `npm run check:format` shorten 'Forward' and move it near 'Reply' where it belongs to reword to 'Encryption Info' reword profile title to 'Profile' reword to 'Switch Account' rare errors are not translated reword to 'Export Backup' add changelog entry use correct autocrypt-setup strings Update translations (02.11.2023) Add entry to CHANGELOG.md Correctly center username next to profile image
|
Thank you for your review comments and confirming that all is good with the links now @Simon-Laux! I like the idea to have an own helper method for the confirmation dialogue, would tackle that in a separate, follow up PR if that makes sense? Also, I assume we will not merge this until the new core is released, right? |
New core 1.129.0 is already released. |
This PR adds a confirmation dialogue for the user when an email link was clicked with a) an unknown contact or b) not-yet-existing chat. The behaviour should be the same across email addresses but also
mailto:links and resemble the UX flow in the Android app.deltachat-2023-11-03_15.59.12.mp4
I've also made a mini refactoring moving the mailto-related logic into a separate file and method, trying to decouple it a little bit more from QR functionality.
Potential blocker: Uses unreleased version of the core (compiled from
main) including a newget_chat_id_by_contact_idRPC method: deltachat/deltachat-core-rust#4918Closes #3458