Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganise some settings acording changes on android & ios #3812

Merged
merged 4 commits into from
May 12, 2024

Conversation

Simon-Laux
Copy link
Member

closes #3809

@Simon-Laux Simon-Laux requested review from r10s and farooqkz May 10, 2024 01:20
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for adapting the dialogs! did not look at the code, some feedback from testing:

  • the button "Send Autocrypt Setup Messages" shall have same style as the other buttons (should look like "Import", "Export", "Password and Account" etc.)

  • the hint "Autocrypt is a new and open specification ..." shall be removed without a replacement

  • there is some space missing between "Videochat" title and value:

    (might be an older issue, no blocker therefore)

otherwise lgtm (i assume the missing strings will be pulled in anyways)

@Simon-Laux
Copy link
Member Author

there is some space missing between "Videochat" title and value:

I'd say that could deserve its own issue, even with space it looks not good enough, maybe it could show the current instance in a subtitle? but that's a topic on it's own, if important enough then make an issue.

remove explaination string and highlight of autocrypt setup button
@Simon-Laux Simon-Laux merged commit 304b05a into master May 12, 2024
4 of 6 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3809-reorganise-some-settings branch May 12, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

reorganise some settings
2 participants