Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: wording for background_sync_disabled #3960

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Jun 19, 2024

It was recently updated in #3717, and became a little awkward. The title could be interpreted as "disable sync for all accounts, including the current one".

It was recently updated in #3717, and became a little awkward.
The title could be interpreted as "disable sync for all accounts,
including the current one".
@WofWca WofWca force-pushed the wofwca/reword-background-sync branch from 06bcd2a to 9d7f1a1 Compare June 19, 2024 11:06
@r10s
Copy link
Member

r10s commented Jun 19, 2024

ftr, "Only Sync Selected Account" was also the initial suggestion at #3684 (issue belonging to #3717), and there were some discussions around that wording

@WofWca
Copy link
Collaborator Author

WofWca commented Jun 19, 2024

I didn't read that.
Ok, feel free to close.

@r10s
Copy link
Member

r10s commented Jun 19, 2024

well, i agree that "Only Sync Selected Account" is easier to understand, esp. with the subtitle explaining things

@Simon-Laux Simon-Laux merged commit 717eb94 into main Jun 19, 2024
2 of 5 checks passed
@Simon-Laux Simon-Laux deleted the wofwca/reword-background-sync branch June 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants