feat: more shortcuts to switch between chats #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Ctrl + PageDown`, `Ctrl + PageUp`, `Ctrl + Tab`, `Ctrl + Shift + Tab` These are used by Telegram: https://github.com/telegramdesktop/tdesktop/wiki/Keyboard-Shortcuts Related MR: #3965
WofWca
added
enhancement
|
I'm not cure about ctrl+tab, we might need it to be a more generic way to navigate through the whole app in the future, also I do not know whether and what key combinations are used or required by screen readers. 🤔 The ones with PageUp and PageDown are fine by me |
|
Update about Mac: Telegram has different shortcuts there https://github.com/overtake/TelegramSwift/wiki , only ⌥⌘↑ Update 2: or no?? overtake/TelegramSwift#826, overtake/TelegramSwift#1118 - says that Ctrl + Tab also works (sometimes). |
|
just checked linux Firefox and macOS safari. seems like I confused it with alt+tab on macOS and tab & shift+tab everywhere else so its fine. |
Simon-Laux
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl + PageDown,Ctrl + PageUp,Ctrl + Tab,Ctrl + Shift + TabThese are used by Telegram: https://github.com/telegramdesktop/tdesktop/wiki/Keyboard-Shortcuts
Related MR: #3965
I tested it a bit. Appears to work, and not break existing "PageUp" shortcut.
Those on Mac, please verify that these shortcuts are alright.see comment about Mac below