style: cancel old message highlight animations #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/highlight-only-one-message
branch
from
6f00432
to
7fa6025
Compare
WofWca
changed the title
WofWca
force-pushed
the
wofwca/highlight-only-one-message
branch
from
7fa6025
to
0bf30de
Compare
nicodh
approved these changes
Oct 11, 2024
I.e. when we highlight a new message as a result of `jumpToMessage`, remove the animation on the previously highlighted message (or messages). This is particularly useful for the Ctrl + Up shortcut which is to choose the message to reply to. Just FYI the added code usually takes 0.1-0.5ms to execute.
WofWca
force-pushed
the
wofwca/highlight-only-one-message
branch
from
0bf30de
to
1a45bc0
Compare
Simon-Laux
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. when we highlight a new message as a result of
jumpToMessage,remove the animation on the previously highlighted message
(or messages).
This is particularly useful for the Ctrl + Up shortcut
which is to choose the message to reply to.
Just FYI the added code usually takes 0.1-0.5ms to execute.