Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use authname instead of displayname for vcard filename #4233

Merged
merged 3 commits into from
Oct 21, 2024
Merged

use authname instead of displayname for vcard filename #4233

merged 3 commits into from
Oct 21, 2024

Conversation

Simon-Laux
Copy link
Member

closes #4230

@Simon-Laux Simon-Laux added the bug Something isn't working label Oct 21, 2024
WofWca
WofWca approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check whether authName is actually "safe", but if it is then this is good.

@Simon-Laux
Copy link
Member Author

Get original contact name.

This is the name of the contact as defined by the contact themself. If the contact themself does not define such a name, an empty string is returned.
https://c.delta.chat/classdc__contact__t.html#a7778540e0592d4c7a480222ea30e9ac8

oh, I just noticed the "empty" string part, I'll fix that

@Simon-Laux Simon-Laux merged commit 1ebcc5a into main Oct 21, 2024
7 checks passed
@Simon-Laux Simon-Laux deleted the simon/i4230-leaked-contact-nickname-in-vcard-filename branch October 21, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WofWca WofWca WofWca approved these changes

@iequidoo iequidoo Awaiting requested review from iequidoo

@maxphilippov maxphilippov Awaiting requested review from maxphilippov

@missytake missytake Awaiting requested review from missytake

@nicodh nicodh Awaiting requested review from nicodh

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharing a contact exposes the custom contact display name in the .vcf file name
2 participants
@Simon-Laux @WofWca