Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: less vertical space between radio buttons #4298

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Oct 31, 2024

The "bug" was introduced in 0e0d0b8.
Now the RadioGroup items are spaced as they were
prior to the aforementioned commit.

This slightly changes the look of the "Video Chat"
section in settings.

Before:
image

After:
image
image
image

@WofWca WofWca force-pushed the wofwca/style-radio-buttons-spacing branch 3 times, most recently from ce6f83d to 41416fd Compare October 31, 2024 13:26
@WofWca WofWca added the ui/ux UI/UX related issues label Oct 31, 2024
@WofWca WofWca force-pushed the wofwca/style-radio-buttons-spacing branch from 41416fd to cc2bef9 Compare October 31, 2024 13:29
@WofWca WofWca marked this pull request as ready for review October 31, 2024 13:29
Copy link
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(small type in comment, not worth changing: "the hiehgt of the radio")

The "bug" was introduced in 0e0d0b8.
Now the `RadioGroup` items are spaced as they were
prior to the aforementioned commit.

This slightly changes the look of the "Video Chat"
section in settings.
@WofWca WofWca force-pushed the wofwca/style-radio-buttons-spacing branch from cc2bef9 to 3894e5c Compare October 31, 2024 14:26
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots lgtm as well :)

@WofWca WofWca merged commit c226e2e into main Oct 31, 2024
10 checks passed
@WofWca WofWca deleted the wofwca/style-radio-buttons-spacing branch October 31, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux UI/UX related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants