add theme support in browser edition #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
the result was not used so I thought maybe the error was used? but turns out it called the wrong electron ipc function. And I can't think of an important reason why it should be fixed instead of removed. we don't store absolute paths for themes in config, maybe we did in the past, but now we certainly don't need it anymore
Simon-Laux
force-pushed
the
simon/browser-themes
branch
from
1f60126
to
23788f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime.resolveThemeAddress.I intentionally left out
--theme-watchfor now. It is semi-hard to implement here and there is not much advantage to developing a theme with the electron version.