Desktop 1.46.0 release #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out the page preview at https://staging.delta.chat/907/en/download |
Simon-Laux
reviewed
Jun 12, 2024
Simon-Laux
reviewed
Jun 12, 2024
Simon-Laux
reviewed
Jun 12, 2024
11 tasks
|
let's do #889 in another PR, eg. we may want to preserve the scanning image and there are minor layout tweaks needed. it also makes sense to postpone that change a bit until 1.46 is really everywhere (eg. fdroid is missing, probably also some desktop repos/stores). all that discussion should be detached from doing chore wrt desktop version. |
r10s
reviewed
Jun 12, 2024
Co-authored-by: bjoern <r10s@b44t.com>
r10s
approved these changes
Jun 13, 2024
Simon-Laux
reviewed
Jun 15, 2024
_includes/download-boxes.html
Outdated
| @@ -154,10 +155,13 @@ <h1>❶ {%if tx.download.install != ""%}{{ tx.download.install }}{%else%}{{ txEn | |||
| {%if tx.download.no_upgrades != ""%}{{ tx.download.no_upgrades }}{%else%}{{ txEn.download.no_upgrades }}{%endif%} | |||
| </summary> | |||
| <div class="buttons"> | |||
| <a href="https://download.delta.chat/desktop/v{{VERSION_DESKTOP}}/deltachat-desktop_{{VERSION_DESKTOP}}_amd64.deb"><small>Get .deb for</small> Debian/Ubuntu</a> | |||
| <a href="https://download.delta.chat/desktop/v{{VERSION_DESKTOP}}/deltachat-desktop-{{VERSION_DESKTOP}}.x86_64.rpm"><small>Get .rpm for</small> Fedora</a> | |||
| <a href="https://download.delta.chat/desktop/v{{VERSION_DESKTOP}}/deltachat-desktop_{{VERSION_DESKTOP}}_amd64.deb"><small>Get .deb for amd64</small> Debian/Ubuntu</a> | |||
There was a problem hiding this comment.
either use x86_64 or amd64 everywhere, otherwise it's confusing, also I'd prefer x86_64 because thats less similar to "arm', like less easy to confuse because more than one letter is different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: deltachat/deltachat-desktop#3929