Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy #362

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

Enable mypy #362

wants to merge 16 commits into from

Commits on Feb 4, 2022

  1. Add maybe_coroutine decorator to allow async/await syntax for twisted

    @gazpachoking
    gazpachoking committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    f98d015 View commit details
    Browse the repository at this point in the history

  2. [Core] Convert inlineCallbacks to maybe_coroutine

    @gazpachoking
    gazpachoking committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    06118c4 View commit details
    Browse the repository at this point in the history

  3. [Core] Document all exported core methods with type hints

    @gazpachoking
    gazpachoking committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    25c6ef9 View commit details
    Browse the repository at this point in the history

  4. Standardize docstrings in core.py to google standard. 

    Remove type hints in docstrings in favor of the ones in method signatures.
    @gazpachoking
    gazpachoking committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    b62832a View commit details
    Browse the repository at this point in the history

  5. Use function signature type hints in autodoc generated docs.

    @gazpachoking
    gazpachoking committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    9ebbaf3 View commit details
    Browse the repository at this point in the history

  6. Fix up core.py for mypy usage 

    Add a mypy config to pyproject.toml
    @gazpachoking
    gazpachoking committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    e0770be View commit details
    Browse the repository at this point in the history

  7. Add project level workaround for mypy twisted.internet.reactor 

    Adds a custom stubs directory that defines twisted.internet.reactor for mypy. This prevents needing to cast the module in every file we want mypy to check.
    @gazpachoking
    gazpachoking committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    f539109 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'maybe_coroutine' into mypy_coroutine 

    # Conflicts:
#	deluge/core/core.py
    @gazpachoking
    gazpachoking committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    cd350d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2022

  1. Add some ignored 3rd party modules without typing to mypy config

    @gazpachoking
    gazpachoking committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    c31d777 View commit details
    Browse the repository at this point in the history

  2. Fix some more mypy issues

    @gazpachoking
    gazpachoking committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    e1fff98 View commit details
    Browse the repository at this point in the history

  3. Keep typing stuff

    @gazpachoking
    gazpachoking committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    209e9bb View commit details
    Browse the repository at this point in the history

  4. Attempt to enable mypy on github actions

    @gazpachoking
    gazpachoking committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    447e3fc View commit details
    Browse the repository at this point in the history

  5. Disable type checking for pytest 

    Add pygobject-stubs
    @gazpachoking
    gazpachoking committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    2b1e718 View commit details
    Browse the repository at this point in the history

  6. Try to get pygobject-stubs working

    @gazpachoking
    gazpachoking committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    9cf57b1 View commit details
    Browse the repository at this point in the history

  7. Add some more type stubs

    @gazpachoking
    gazpachoking committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    15a63d8 View commit details
    Browse the repository at this point in the history

  8. Ignore win32 types

    @gazpachoking
    gazpachoking committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    6f522bd View commit details
    Browse the repository at this point in the history