Create class for each node type #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-tymoshenko
force-pushed
the
create-class-for-each-node-type
branch
3 times, most recently
from
203bcf1
to
7a4dbe5
Compare
|
Main branch:
Current branch:
|
ivan-tymoshenko
force-pushed
the
create-class-for-each-node-type
branch
2 times, most recently
from
3120a27
to
5665a92
Compare
ivan-tymoshenko
force-pushed
the
create-class-for-each-node-type
branch
from
5665a92
to
7c7fe6e
Compare
|
Is the difference in the last benchmark in the script confirmed? Are we losing some perf? |
|
There is no reason for the last benchmark to be slower. I ran it again in the current branch.
Benchmarks can have a significant margin of error between two runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the Node entity: