Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters decoding #282

Merged
merged 1 commit into from
May 17, 2022
Merged

Fix parameters decoding #282

merged 1 commit into from
May 17, 2022

Conversation

ivan-tymoshenko
Copy link
Collaborator

Fix #234 and a bunch of optimization to make it work as fast as possible.

@ivan-tymoshenko
Copy link
Collaborator Author

Снимок экрана 2022-05-13 в 23 42 58

@mcollina
Copy link
Collaborator

@Eomm could you take a look?

Copy link
Contributor

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR looks GREAT!

Just suggesting a test case for double-decoding check

test/issue-234.test.js Show resolved Hide resolved
test/issue-234.test.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ab1f292 into main May 17, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the fix-parameters-decoding branch May 18, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoding URL Components
3 participants