-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add querrystring parser #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update the docs?
223afcb
to
ceaddd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Can you fix the conflicts? |
ceaddd1
to
9c9f677
Compare
Can you fix the conflicts (sorry)? |
9c9f677
to
437eab2
Compare
Wow |
We are already searching the querystring in the path and are spending some time on it. I want to pass the querystring to the handler instead of parsing it again in the handler. The querystring would be passed to the handler as a new argument.
+ find-my-way handle ';' as a querystring start symbol and fastify doesn't.
The changes to the fastify:
ivan-tymoshenko/fastify@00087f0
Benchmarks:
In the main branch, I added a handler that parses querystring in the same way as fastify does
(https://github.com/fastify/fastify/blob/0a4649f504bd466ce7dd37b510832746b213b2d4/lib/route.js#L377) and compared it with parsing a querystring natively in the find-my-way.
Handler in the main branch: