Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using local postgres for pytest #843

Merged
merged 16 commits into from
Aug 21, 2023
Merged

Using local postgres for pytest #843

merged 16 commits into from
Aug 21, 2023

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Aug 21, 2023 •
edited
Loading

  1. Spinning local postgres container for testing (system-test: Use postgres in tests instead of sqlite #836)
  2. Using conftest for test fixtures to avoid importing fixture dependencies in tests
  3. Fixing rounding bugs with fixedpoint (Fixed point should not accept floating point in constructor fixedpointmath#21)

@vercel
Copy link

vercel bot commented Aug 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elf-simulations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 10:44pm

@slundqui slundqui marked this pull request as ready for review August 21, 2023 21:01
sentilesdal
sentilesdal approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only smol things

conftest.py Show resolved Hide resolved
lib/chainsync/chainsync/test_fixtures/db_session.py Show resolved Hide resolved
lib/chainsync/chainsync/test_fixtures/db_session.py Outdated Show resolved Hide resolved
lib/chainsync/chainsync/db/hyperdrive/schema.py Show resolved Hide resolved
tests/system_test.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
conftest.py Show resolved Hide resolved
dpaiton
dpaiton approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I would prefer if we added e.g. Decimal(FixedPoint("5.2")) support instead of the helper function.

@slundqui slundqui merged commit e4d4b57 into delvtech:main Aug 21, 2023
@slundqui slundqui deleted the postgres_tests branch August 21, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentilesdal sentilesdal sentilesdal approved these changes

@dpaiton dpaiton dpaiton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slundqui @dpaiton @sentilesdal