Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ne pas merger : rename expression_reguliere_champ to formatted_champ #10819

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

krichtof
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (ee9a493) to head (5d9600e).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
app/models/procedure_revision.rb 53.84% 6 Missing ⚠️
app/validators/simple_formatted_champ_validator.rb 92.85% 2 Missing ⚠️
...ssion_reguliere_type_de_champ_to_formatted_task.rb 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10819      +/-   ##
==========================================
+ Coverage   84.37%   84.40%   +0.03%     
==========================================
  Files        1176     1189      +13     
  Lines       25949    26093     +144     
  Branches     4898     4942      +44     
==========================================
+ Hits        21894    22024     +130     
- Misses       4055     4069      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krichtof krichtof force-pushed the 10201-champ-formate branch 12 times, most recently from 6952284 to 3d30ff2 Compare November 27, 2024 11:45
@krichtof krichtof force-pushed the 10201-champ-formate branch 2 times, most recently from c72c807 to 1b1af61 Compare December 4, 2024 13:07
@krichtof krichtof changed the title WIP : rename expression_reguliere_champ to formatted_champ Ne pas merger : rename expression_reguliere_champ to formatted_champ Dec 4, 2024
@krichtof krichtof marked this pull request as ready for review December 4, 2024 13:30
Co-Authored-By: Christophe Robillard <christophe.robillard@mail.numerique.gouv.fr>
Co-Authored-By: simon lehericey <mail@simon.lehericey.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants