-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETQ instructeur, je peux passer au dossiers suivant ou au dossier précédent lorsque je visualise un dossiers d'un des onglet (a-suivre, tous, ...) #10898
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10898 +/- ##
==========================================
+ Coverage 84.43% 84.47% +0.04%
==========================================
Files 1182 1185 +3
Lines 26112 26234 +122
Branches 4920 4943 +23
==========================================
+ Hits 22047 22162 +115
- Misses 4065 4072 +7 ☔ View full report in Codecov by Sentry. |
2b29962
to
cfa245e
Compare
cfa245e
to
018c0a2
Compare
ffc6438
to
2ca10f0
Compare
8a56028
to
7972027
Compare
def retrieve_procedure_presentation | ||
@procedure_presentation ||= current_instructeur.procedure_presentation_for_procedure_id(params[:procedure_id]) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je me demande si on mettrait pas ça dans un InstructeurConcern
, je le trouve un peu spécifique pour être dans ApplicationController
?
5b2fc26
to
a724fee
Compare
…Pagination to next/previous dossiers by statut. also responsible to fetch next/previous page
…ews list of dossier, caches current loaded page
…esentation from anywhere (target: will be used by Cache::ProcedureDossierPagination)
…om a dossier id to either a next dossier, either a previous
…and next/prev within a component
6b1822b
to
cb0b1b5
Compare
ensure next/prev links are always on oneline, make back button bigger [same as design], align back/next/prev to top when there is more than oneline for h1 [either procedure name, either dossier name]
cb0b1b5
to
af5af67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top ! ça fonctionne nickel
6e5aa90
dependeds_on: #10877closes: #10896, https://github.com/orgs/demarches-simplifiees/projects/1/views/1?filterQuery=suivant&pane=issue&itemId=52248127&issue=demarches-simplifiees%7Cdemarches-simplifiees.fr%7C9962
probleme
ETQ instructeur, j'aimerais ne pas avoir a faire des allers/retours entre la liste des dossiers et un dossier
solution
next-prev.mov