Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ instructeur, je peux passer au dossiers suivant ou au dossier précédent lorsque je visualise un dossiers d'un des onglet (a-suivre, tous, ...) #10898

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Oct 7, 2024

dependeds_on: #10877

closes: #10896, https://github.com/orgs/demarches-simplifiees/projects/1/views/1?filterQuery=suivant&pane=issue&itemId=52248127&issue=demarches-simplifiees%7Cdemarches-simplifiees.fr%7C9962

probleme

ETQ instructeur, j'aimerais ne pas avoir a faire des allers/retours entre la liste des dossiers et un dossier

solution

next-prev.mov

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 94.40000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.47%. Comparing base (b848179) to head (af5af67).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...ents/instructeurs/dossiers_navigation_component.rb 84.61% 4 Missing ⚠️
app/models/cache/procedure_dossier_pagination.rb 95.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10898      +/-   ##
==========================================
+ Coverage   84.43%   84.47%   +0.04%     
==========================================
  Files        1182     1185       +3     
  Lines       26112    26234     +122     
  Branches     4920     4943      +23     
==========================================
+ Hits        22047    22162     +115     
- Misses       4065     4072       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo mfo force-pushed the US/navigation-accros-dossiers branch from 2b29962 to cfa245e Compare October 7, 2024 21:34
@mfo mfo force-pushed the US/navigation-accros-dossiers branch from cfa245e to 018c0a2 Compare November 15, 2024 09:13
@mfo mfo force-pushed the US/navigation-accros-dossiers branch 12 times, most recently from ffc6438 to 2ca10f0 Compare November 29, 2024 11:00
@mfo mfo changed the title WIP – Us/navigation next/prev accros dossiers ETQ instructeur, je peux passer au dossiers suivant ou au dossier précédent lorsque je visualise un dossiers d'un des onglet (a-suivre, tous, ...) Nov 29, 2024
@mfo mfo force-pushed the US/navigation-accros-dossiers branch 4 times, most recently from 8a56028 to 7972027 Compare December 2, 2024 10:22
Comment on lines 430 to 432
def retrieve_procedure_presentation
@procedure_presentation ||= current_instructeur.procedure_presentation_for_procedure_id(params[:procedure_id])
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me demande si on mettrait pas ça dans un InstructeurConcern, je le trouve un peu spécifique pour être dans ApplicationController ?

app/controllers/instructeurs/dossiers_controller.rb Outdated Show resolved Hide resolved
app/controllers/instructeurs/dossiers_controller.rb Outdated Show resolved Hide resolved
app/models/cache/procedure_dossier_pagination.rb Outdated Show resolved Hide resolved
app/models/cache/procedure_dossier_pagination.rb Outdated Show resolved Hide resolved
app/models/cache/procedure_dossier_pagination.rb Outdated Show resolved Hide resolved
@mfo mfo force-pushed the US/navigation-accros-dossiers branch from 5b2fc26 to a724fee Compare December 10, 2024 08:14
mfo added 5 commits December 10, 2024 09:15
…Pagination to next/previous dossiers by statut. also responsible to fetch next/previous page
…ews list of dossier, caches current loaded page
…esentation from anywhere (target: will be used by Cache::ProcedureDossierPagination)
…om a dossier id to either a next dossier, either a previous
@mfo mfo force-pushed the US/navigation-accros-dossiers branch 2 times, most recently from 6b1822b to cb0b1b5 Compare December 10, 2024 08:19
ensure next/prev links are always on oneline, make back button bigger
[same as design], align back/next/prev to top when there is more than
oneline for h1 [either procedure name, either dossier name]
@mfo mfo force-pushed the US/navigation-accros-dossiers branch from cb0b1b5 to af5af67 Compare December 10, 2024 09:22
Copy link
Contributor

@mmagn mmagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top ! ça fonctionne nickel

@mfo mfo added this pull request to the merge queue Dec 11, 2024
Merged via the queue into demarches-simplifiees:main with commit 6e5aa90 Dec 11, 2024
18 checks passed
@mfo mfo deleted the US/navigation-accros-dossiers branch December 11, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants