ETQ instructeur, je peux inclure les dossiers "archivés" quand je télécharge les dossiers de l'onglet "Au total" #11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11113 +/- ##
==========================================
- Coverage 84.44% 84.43% -0.02%
==========================================
Files 1182 1182
Lines 26112 26130 +18
Branches 4923 4932 +9
==========================================
+ Hits 22050 22062 +12
- Misses 4062 4068 +6 ☔ View full report in Codecov by Sentry. |
mmagn
force-pushed
the
fix-11103
branch
4 times, most recently
from
140985d to
1444628
Compare
colinux
reviewed
Dec 9, 2024
| @@ -29,6 +30,18 @@ def allowed_format?(item) | |||
| item.fetch(:format) != :json || @procedure.active_revision.carte? | |||
| end | |||
|
|
|||
| def can_include_archived? | |||
There was a problem hiding this comment.
je me demande si cette méthode ne devrait pas aussi embarquer la logique de && @archived_count > 1 pour que les views n'ont pas à s'en occuper
There was a problem hiding this comment.
Oui je suis d'accord. je fais la modif
db/schema.rb
Outdated
There was a problem hiding this comment.
y a pas mal de changes qui n'ont rien à voir avec cette pr ;)
|
@colinux c'est reglé, merci pour ta review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11103
