Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where is existing key and isn't existing key dont'… #15339

Merged
merged 3 commits into from
Oct 24, 2021
Merged

Conversation

spearmin10
Copy link
Contributor

… work.

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/S

Description

  • Fixed an issue where is existing key and isn't existing key don't work
  • Revised mistakes in the document

Minimum version of Cortex XSOAR

  • 5.5.0
  • 6.0.0
  • 6.1.0
  • 6.2.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Oct 17, 2021
@content-bot content-bot changed the base branch from master to contrib/spearmin10_ExtFilter October 17, 2021 06:25
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @iyeshaya will know he can start review the proposed changes.

@content-bot content-bot requested a review from iyeshaya October 17, 2021 06:25
@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Oct 17, 2021
@content-bot
Copy link
Collaborator

The CircleCI check from your latest pushed commit was unsuccessful. @spearmin10 take a look at the build by clicking this link.


Failed Build Steps

  • Validate Files and Yaml

Try and address the listed CircleCI build step failures at your earliest convenience. This will greatly expedite the process of getting your proposed changes merged into master. Happy coding and may the force be with you.

@@ -0,0 +1,8986 @@
Filter values with complex conditions.<br/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file should be here, please remove it.

@iyeshaya iyeshaya merged commit 4edebc1 into demisto:contrib/spearmin10_ExtFilter Oct 24, 2021
iyeshaya added a commit that referenced this pull request Oct 24, 2021
#15339) (#15437)

* Fixed an issue where `is existing key` and `isn't existing key` dont' work.

* Modified pack_metadata.json

* Delete README.md.orig

Co-authored-by: iyeshaya <81752898+iyeshaya@users.noreply.github.com>

Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
Co-authored-by: iyeshaya <81752898+iyeshaya@users.noreply.github.com>
@spearmin10 spearmin10 deleted the ExtFilter branch October 25, 2021 00:55
wissamg pushed a commit that referenced this pull request Nov 1, 2021
#15339) (#15437)

* Fixed an issue where `is existing key` and `isn't existing key` dont' work.

* Modified pack_metadata.json

* Delete README.md.orig

Co-authored-by: iyeshaya <81752898+iyeshaya@users.noreply.github.com>

Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
Co-authored-by: iyeshaya <81752898+iyeshaya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants