Misp v3 delete attribute + local tag arg #17742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakatzir
reviewed
Feb 17, 2022
Packs/MISP/pack_metadata.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "MISP", | |||
| "description": "Malware information and threat sharing platform.", | |||
| "support": "xsoar", | |||
| "currentVersion": "2.0.6", | |||
| "currentVersion": "2.0.7", | |||
There was a problem hiding this comment.
Should bump a minor as I see it https://semver.org/.
bakatzir
reviewed
Feb 17, 2022
Packs/MISP/ReleaseNotes/2_0_7.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| #### Integrations | |||
| ##### MISP v3 | |||
| - Added new command ***misp-delete-attribute***. | |||
There was a problem hiding this comment.
Suggested change
| - Added new command ***misp-delete-attribute***. | |
| - Added the command ***misp-delete-attribute*** which allow users to delete an attribute according to the given attribute ID. |
guykeller
approved these changes
Feb 20, 2022
Packs/MISP/ReleaseNotes/2_1_0.md
Outdated
Comment on lines
3
to
5
| - Added the command ***misp-delete-attribute*** which allow users to delete an attribute according to the given attribute ID. | ||
| - In the **misp-add-tag-to-event** command the *is_local* argument was added. | ||
| - In the **misp-add-tag-to-attribute** command the *is_local* argument was added. |
There was a problem hiding this comment.
Suggested change
| - Added the command ***misp-delete-attribute*** which allow users to delete an attribute according to the given attribute ID. | |
| - In the **misp-add-tag-to-event** command the *is_local* argument was added. | |
| - In the **misp-add-tag-to-attribute** command the *is_local* argument was added. | |
| - Added the command ***misp-delete-attribute*** which allows users to delete an attribute according to a given attribute ID. | |
| - Added the *is_local* argument to the **misp-add-tag-to-event** command. | |
| - Added the *is_local* argument to the **misp-add-tag-to-attribute** command. |
|
Link to the unit tests coverage report: |
|
The following integrations/tests were collected by the CI build but are currently skipped. The collected tests are related to this pull request and might be critical.:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://github.com/demisto/etc/issues/46774
Description
Screenshots
*1
*2
*3
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have
@bakatzir FYI