Automox XSOAR Content Pack #18404

ax-jmiller · 2022-04-01T15:19:28Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

This pull request introduces the Automox Content Pack, including an integration and playbook for interfacing with the Automox platform through XSOAR.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

6.0.0
6.1.0
6.2.0
6.5.0

Does it break backward compatibility?

Yes
- Further details:
No

Must have

Tests
Documentation

* IN-104 Implemented commands related to Administration and Vulnerability Sync use cases.

Added playbook to automate report uploads

Added documentation for Playbook, Integration, and Pack

* Adding unit tests * Reviewed checklist for XSOAR submission

CLAassistant · 2022-04-01T15:19:37Z

All committers have signed the CLA.

content-bot · 2022-04-01T15:20:52Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yaakovi will know he can start review the proposed changes.

content-bot · 2022-04-01T15:57:41Z

The CircleCI check from your latest pushed commit was unsuccessful. @ax-jmiller take a look at the build by clicking this link.

Failed Build Steps

Run Unit Testing and Lint

Try and address the listed CircleCI build step failures at your earliest convenience. This will greatly expedite the process of getting your proposed changes merged into master. Happy coding and may the force be with you.

MLainer1

Great work! looks great :)
Make sure to go over the comments that I made and request another review when you need it

Packs/Automox/Integrations/Automox/Automox.py

Packs/Automox/Integrations/Automox/Automox.yml

…hon. Fixed issues with fromversion and tests in Integration yaml.

content-bot · 2022-04-06T19:10:06Z

The CircleCI build failed again. @ax-jmiller take a look at the build details here - and try and fix the issues so that we can merge your proposed changes as soon as possible.

Failed Build Steps

Check if CircleCI's config file and requirements.txt files are up to date

ax-jmiller · 2022-04-06T19:56:23Z

When I fetched upstream changes for my fork from github, it merged all the commits into the history for this branch, which is kind of messy. What would you recommend here?

MLainer1

Thank you for your time in the demo. Make sure to address the notes that we raised regarding the integration. Feel free to send me a message if you have any questions, and request a review when you are done :)

…l codes

… key

MLainer1

Great work :)
Make sure to look at the failed validation in the pr, it looks like a quick fix, and make sure to merge from master

Packs/Automox/Integrations/Automox/Automox.yml

content-bot · 2022-04-19T14:36:57Z

The CircleCI build failed again. @ax-jmiller take a look at the build details here - and try and fix the issues so that we can merge your proposed changes as soon as possible.

Failed Build Steps

Check if CircleCI's config file and requirements.txt files are up to date
Validate Files and Yaml

Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>

content-bot · 2022-04-19T15:37:07Z

The CircleCI build failed again. @ax-jmiller take a look at the build details here - and try and fix the issues so that we can merge your proposed changes as soon as possible.

Failed Build Steps

Validate Files and Yaml
Check if CircleCI's config file and requirements.txt files are up to date

…ntent into automox-xsoar-pack

content-bot · 2022-04-21T07:40:55Z

The CircleCI build failed again. @ax-jmiller take a look at the build details here - and try and fix the issues so that we can merge your proposed changes as soon as possible.

Failed Build Steps

Check if CircleCI's config file and requirements.txt files are up to date

content-bot · 2022-04-24T06:28:43Z

Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/2810014

* Automox Content Pack for XSOAR (#1) * IN-104 Implemented commands related to Administration and Vulnerability Sync use cases. * [IN-149] Adding Vulnerability Upload Playbook (#2) Added playbook to automate report uploads * [IN-152] Automox XSOAR Documentation (#3) Added documentation for Playbook, Integration, and Pack * IN-166 Automox XSOAR Unit Tests (#4) * Adding unit tests * Reviewed checklist for XSOAR submission * Cleaning up integration test files * Fixed validation issues with playbook * Updated README and Integration yaml to be consistent with args in Python. Fixed issues with fromversion and tests in Integration yaml. * Playbook documentation updates regarding supported csv formats * Present errors in a pleasant and readable way. Handled basic http fail codes * Updated delete commands to update objects in the context with deleted key * Removed test playbook from integration yaml Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> * Added Automox integration instrumentation * Fixed docker image version and schema validation in integration yaml Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: Jack Miller <94870866+ax-jmiller@users.noreply.github.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>

ax-jmiller added 4 commits March 9, 2022 16:57

Automox Content Pack for XSOAR (#1)

a712d74

* IN-104 Implemented commands related to Administration and Vulnerability Sync use cases.

[IN-149] Adding Vulnerability Upload Playbook (#2)

1437d57

Added playbook to automate report uploads

[IN-152] Automox XSOAR Documentation (#3)

74fdf10

Added documentation for Playbook, Integration, and Pack

IN-166 Automox XSOAR Unit Tests (#4)

de50e8f

* Adding unit tests * Reviewed checklist for XSOAR submission

content-bot added the Contribution Thank you! Contributions are always welcome! label Apr 1, 2022

content-bot changed the base branch from master to contrib/ax-jmiller_automox-xsoar-pack April 1, 2022 15:20

content-bot assigned yaakovi Apr 1, 2022

content-bot requested a review from yaakovi April 1, 2022 15:20

ax-jmiller added 2 commits April 1, 2022 11:24

Cleaning up integration test files

8cd2afa

Fixed validation issues with playbook

2dca4d0

Merge remote-tracking branch 'upstream/master' into automox-xsoar-pack

8abb3f2

ax-jmiller marked this pull request as ready for review April 4, 2022 15:05

yaakovi requested review from MLainer1 and removed request for yaakovi April 5, 2022 10:40

yaakovi assigned MLainer1 and unassigned yaakovi Apr 5, 2022

content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Apr 5, 2022

MLainer1 requested changes Apr 6, 2022

View reviewed changes

MLainer1 assigned tomer-pan Apr 6, 2022

Updated README and Integration yaml to be consistent with args in Pyt…

538c5e6

…hon. Fixed issues with fromversion and tests in Integration yaml.

Merge branch 'demisto:master' into automox-xsoar-pack

9f24508

ax-jmiller requested a review from MLainer1 April 6, 2022 19:56

MLainer1 requested a review from tomer-pan April 11, 2022 08:57

MLainer1 added the pending-demo Demo pending label Apr 13, 2022

MLainer1 added post-demo and removed pending-demo Demo pending labels Apr 14, 2022

MLainer1 reviewed Apr 14, 2022

View reviewed changes

ax-jmiller added 3 commits April 15, 2022 16:16

Playbook documentation updates regarding supported csv formats

c3057c9

Present errors in a pleasant and readable way. Handled basic http fai…

0e44d1f

…l codes

Updated delete commands to update objects in the context with deleted…

f8f4464

… key

MLainer1 requested changes Apr 19, 2022

View reviewed changes

Packs/Automox/Integrations/Automox/Automox.yml Outdated Show resolved Hide resolved

Removed test playbook from integration yaml

c42fd4c

Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>

ax-jmiller added 4 commits April 21, 2022 01:53

Added Automox integration instrumentation

842d6b7

Merge remote-tracking branch 'upstream/master' into automox-xsoar-pack

51c487a

Merge branch 'automox-xsoar-pack' of https://github.com/ax-jmiller/co…

711eae9

…ntent into automox-xsoar-pack

Fixed docker image version and schema validation in integration yaml

5a5153c

Merge remote-tracking branch 'upstream/master' into automox-xsoar-pack

2b2dc04

ax-jmiller requested a review from MLainer1 April 21, 2022 07:45

MLainer1 added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Apr 24, 2022

MLainer1 added the docs-approved label Apr 24, 2022

MLainer1 approved these changes Apr 24, 2022

View reviewed changes

MLainer1 merged commit e3ba1e9 into demisto:contrib/ax-jmiller_automox-xsoar-pack Apr 24, 2022

content-bot mentioned this pull request Apr 24, 2022

Automox XSOAR Content Pack #18706

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automox XSOAR Content Pack #18404

Automox XSOAR Content Pack #18404

ax-jmiller commented Apr 1, 2022 •

edited

Loading

CLAassistant commented Apr 1, 2022 •

edited

Loading

content-bot commented Apr 1, 2022

content-bot commented Apr 1, 2022

MLainer1 left a comment

content-bot commented Apr 6, 2022

ax-jmiller commented Apr 6, 2022

MLainer1 left a comment

MLainer1 left a comment

content-bot commented Apr 19, 2022

content-bot commented Apr 19, 2022

content-bot commented Apr 21, 2022

content-bot commented Apr 24, 2022 •

edited

Loading

Automox XSOAR Content Pack #18404

Automox XSOAR Content Pack #18404

Conversation

ax-jmiller commented Apr 1, 2022 • edited Loading

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Screenshots

Minimum version of Cortex XSOAR

Does it break backward compatibility?

Must have

CLAassistant commented Apr 1, 2022 • edited Loading

content-bot commented Apr 1, 2022

content-bot commented Apr 1, 2022

Failed Build Steps

MLainer1 left a comment

Choose a reason for hiding this comment

content-bot commented Apr 6, 2022

Failed Build Steps

ax-jmiller commented Apr 6, 2022

MLainer1 left a comment

Choose a reason for hiding this comment

MLainer1 left a comment

Choose a reason for hiding this comment

content-bot commented Apr 19, 2022

Failed Build Steps

content-bot commented Apr 19, 2022

Failed Build Steps

content-bot commented Apr 21, 2022

Failed Build Steps

content-bot commented Apr 24, 2022 • edited Loading

ax-jmiller commented Apr 1, 2022 •

edited

Loading

CLAassistant commented Apr 1, 2022 •

edited

Loading

content-bot commented Apr 24, 2022 •

edited

Loading