-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workday Sign on Event Collector #28832
Conversation
…on-event-collector
…on-event-collector
…on-event-collector
…into workday-signon-event-collector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Check my comments and make sure to fix the pre-commit and validation issues.
|
||
Use this integration to collect Signon events automatically from Workday. | ||
|
||
In order to use this integration, you need to enter your Workday credentials in the relevant integration instance parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some instructions on how to get the credentials in workday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have an instance, so this may be a bit tricky.
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.yml
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.yml
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignonEventGenerator/README.md
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignonEventGenerator/WorkdaySignonEventGenerator.yml
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
…on-event-collector
…on-event-collector
Packs/Workday/Integrations/WorkdaySignOnEventCollector/README.md
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/README.md
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/README.md
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/README.md
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/README.md
Outdated
Show resolved
Hide resolved
@JasBeilin @yuvalbenshalom Doc review completed. |
…into workday-signon-event-collector
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments to the duplication filtering.
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/Workday/Integrations/WorkdaySignOnEventCollector/WorkdaySignOnEventCollector_test.py
Outdated
Show resolved
Hide resolved
…on-event-collector
…into workday-signon-event-collector
…on-event-collector
…on-event-collector
|
||
#### Context Output | ||
|
||
There is no context output for this command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is outputs I think but since its for developing I think its ok to leave it.
section: Connect | ||
advanced: true | ||
- additionalinfo: The maximum number of sign on events to retrieve. Large amount of events may cause performance issues. | ||
defaultvalue: '10000' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the number we can handle in a minute? Isn't it too big?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Product wanted it increased to 10,000 on the demo. We should be okay to handle it.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6235
Description
A few sentences describing the overall goals of the pull request's commits.
Must have