Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workday Sign on Event Collector #28832

Merged
merged 67 commits into from
Sep 7, 2023
Merged

Conversation

amshamah419
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6235

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@amshamah419 amshamah419 self-assigned this Aug 8, 2023
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Check my comments and make sure to fix the pre-commit and validation issues.


Use this integration to collect Signon events automatically from Workday.

In order to use this integration, you need to enter your Workday credentials in the relevant integration instance parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some instructions on how to get the credentials in workday?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have an instance, so this may be a bit tricky.

Packs/Workday/README.md Outdated Show resolved Hide resolved
Packs/Workday/README.md Outdated Show resolved Hide resolved
Packs/Workday/ReleaseNotes/1_4_0.md Outdated Show resolved Hide resolved
Packs/Workday/ReleaseNotes/1_4_0.md Outdated Show resolved Hide resolved
Packs/Workday/ReleaseNotes/1_4_0.md Outdated Show resolved Hide resolved
@ShirleyDenkberg ShirleyDenkberg self-assigned this Sep 5, 2023
@ShirleyDenkberg
Copy link
Contributor

@JasBeilin @yuvalbenshalom Doc review completed.

amshamah419 and others added 4 commits September 5, 2023 21:10
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments to the duplication filtering.


#### Context Output

There is no context output for this command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is outputs I think but since its for developing I think its ok to leave it.

section: Connect
advanced: true
- additionalinfo: The maximum number of sign on events to retrieve. Large amount of events may cause performance issues.
defaultvalue: '10000'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the number we can handle in a minute? Isn't it too big?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product wanted it increased to 10,000 on the demo. We should be okay to handle it.

@amshamah419 amshamah419 merged commit 88aba41 into master Sep 7, 2023
@amshamah419 amshamah419 deleted the workday-signon-event-collector branch September 7, 2023 11:48
moishce pushed a commit that referenced this pull request Sep 14, 2023
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants