-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for the fetch incidents last_run of ThreatConnectV3 #28935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'origin/master' into ThreatConnect-fetch-last-run-bug-fix
DeanArbel
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
|
||
##### ThreatConnect v3 | ||
- Updated the Docker image to: *demisto/python3:3.10.12.68714*. | ||
- Fixed an issue where the ***fetch-incident*** command didnt update correctly the fetch time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- Fixed an issue where the ***fetch-incident*** command didnt update correctly the fetch time. | |
- Fixed an issue where the ***fetch-incident*** command didn't correctly update the fetch time. |
@DeanArbel Doc review completed. |
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* fixed the last_run of ThreatconnectV3 + added some UT * 2 more tests for the fetch * fixed an issue with the fetch-indicents parameters * Added release notes and updated docker image * Bump pack from version ThreatConnect to 3.0.10. * updated release notes after auto-bump --------- Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
upon an empty response, the integration set an invalid last_run instead of taking the previous last run
Must have