Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for the fetch incidents last_run of ThreatConnectV3 #28935

Merged
merged 8 commits into from
Aug 23, 2023

Conversation

omerKarkKatz
Copy link
Contributor

@omerKarkKatz omerKarkKatz commented Aug 13, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

upon an empty response, the integration set an invalid last_run instead of taking the previous last run

Must have

  • Tests
  • Documentation

@omerKarkKatz omerKarkKatz marked this pull request as ready for review August 23, 2023 08:49
@omerKarkKatz omerKarkKatz requested a review from DeanArbel August 23, 2023 08:51
@omerKarkKatz omerKarkKatz self-assigned this Aug 23, 2023
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job


##### ThreatConnect v3
- Updated the Docker image to: *demisto/python3:3.10.12.68714*.
- Fixed an issue where the ***fetch-incident*** command didnt update correctly the fetch time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed an issue where the ***fetch-incident*** command didnt update correctly the fetch time.
- Fixed an issue where the ***fetch-incident*** command didn't correctly update the fetch time.

@ShirleyDenkberg
Copy link
Contributor

@DeanArbel Doc review completed.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • ThreatConnect pack version was bumped to 3.0.10.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@omerKarkKatz omerKarkKatz merged commit c31a44e into master Aug 23, 2023
@omerKarkKatz omerKarkKatz deleted the ThreatConnect-fetch-last-run-bug-fix branch August 23, 2023 14:54
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* fixed the last_run of ThreatconnectV3 + added some UT

* 2 more tests for the fetch

* fixed an issue with the fetch-indicents parameters

* Added release notes and updated docker image

* Bump pack from version ThreatConnect to 3.0.10.

* updated release notes after auto-bump

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants