Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packs/GoogleDrive: add modify labels command #28962

Conversation

GalNakash-RecoLabs
Copy link
Contributor

Add a command to modify labels in google drive

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Aug 14, 2023
@content-bot content-bot changed the base branch from master to contrib/RecoLabs_google-modify-label August 14, 2023 18:23
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ostolero will know the proposed changes are ready to be reviewed.

@content-bot content-bot requested a review from ostolero August 14, 2023 18:24
Add a command to modify labels in google drive

Signed-off-by: Gal Nakash <gal@recolabs.ai>
Generate docs based on yaml

Signed-off-by: Gal Nakash <gal@recolabs.ai>
@edik24 edik24 removed their assignment Aug 15, 2023
Get labels command to get all labels in google drive

Signed-off-by: Gal Nakash <gal@recolabs.ai>
@GalNakash-RecoLabs GalNakash-RecoLabs force-pushed the google-modify-label branch 2 times, most recently from 2938e86 to e61fcb1 Compare August 15, 2023 09:22
Add command to get labels attached to file

Signed-off-by: Gal Nakash <gal@recolabs.ai>
@GalNakash-RecoLabs
Copy link
Contributor Author

PR is ready!

Copy link
Contributor

@ostolero ostolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gal, great work!
Everything is really according to out standard and looks great, just a few points-

  1. see my comment regarding adding the logger decorator.
  2. There are 2 validation failures in the build, the first one is regarding the use of demisto.log (see comment). the second is regarding the use of demisto.results in main. this is not part of your code but if you can change that line to simply return that would be greatly appreciated :)
  3. You should add another unit test for the coverage test to pass.
    Let me you know if you need any help, I've reached out through slack to schedule a demo :)

@ostolero ostolero added the pending-demo Demo pending label Aug 16, 2023
Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com>
Return result instead of return

Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
@GalNakash-RecoLabs GalNakash-RecoLabs force-pushed the google-modify-label branch 3 times, most recently from 9af51f0 to 42c52f4 Compare August 20, 2023 14:14
@ostolero ostolero added post-demo and removed pending-demo Demo pending labels Aug 20, 2023
@ostolero
Copy link
Contributor

Thank you Gal for a great demo!
During the demo we added proper Human readable outputs, and as discussed we still require outputs for the new commands in the yml. here is the sdk command that helps achieve this.
when these are finished and all validation pass we can merge :)

Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
@ostolero
Copy link
Contributor

The context is approved by @melamedbn , need to fix the last validation failures

ostolero and others added 2 commits August 21, 2023 16:59
Signed-off-by: Gal Nakash <gal@recolabs.ai>
@GalNakash-RecoLabs
Copy link
Contributor Author

@ostolero anything from my side?

Copy link
Contributor

@ostolero ostolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great!

@ostolero
Copy link
Contributor

Hi Gal ,I approved as all the changes are done :) merging this and when the internal pr passes validations we can merge to master. I'll update over Slack when this is expected to show in the marketplace for the client.

@ostolero ostolero merged commit 22e90e7 into demisto:contrib/RecoLabs_google-modify-label Aug 22, 2023
ostolero added a commit that referenced this pull request Aug 23, 2023
* packs/GoogleDrive: add modify labels command

Add a command to modify labels in google drive



* packs/GoogleDrive: add modify labels command readme

Generate docs based on yaml



* packs/GoogleDrive: add get labels command

Get labels command to get all labels in google drive



* packs/GoogleDrive: get-file-labels command

Add command to get labels attached to file



* packs/GoogleDrive: update version 1.2.40



* packs/GoogleDrive: update release notes



* Update Packs/GoogleDrive/Integrations/GoogleDrive/GoogleDrive.py



* packs/GoogleDrive: fix return value

Return result instead of return



* packs/GoogleDrive: add a test for list labels



* packs/GoogleDrive: add a test for modify label



* packs/GoogleDrive: rename test files



* packs/GoogleDrive: added context path for GoogleDrive modify lables



* packs/GoogleDrive: added context path for GoogleDrive get file labels



* packs/GoogleDrive: added context path for GoogleDrive get labels



* packs/GoogleDrive: format file and fix test



* update readme

* update docker

* packs/reco: fix test



---------

Signed-off-by: Gal Nakash <gal@recolabs.ai>
Co-authored-by: GalNakash-RecoLabs <71227802+GalNakash-RecoLabs@users.noreply.github.com>
Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com>
Co-authored-by: ostolero <ostolero@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
…#29125)

* packs/GoogleDrive: add modify labels command

Add a command to modify labels in google drive



* packs/GoogleDrive: add modify labels command readme

Generate docs based on yaml



* packs/GoogleDrive: add get labels command

Get labels command to get all labels in google drive



* packs/GoogleDrive: get-file-labels command

Add command to get labels attached to file



* packs/GoogleDrive: update version 1.2.40



* packs/GoogleDrive: update release notes



* Update Packs/GoogleDrive/Integrations/GoogleDrive/GoogleDrive.py



* packs/GoogleDrive: fix return value

Return result instead of return



* packs/GoogleDrive: add a test for list labels



* packs/GoogleDrive: add a test for modify label



* packs/GoogleDrive: rename test files



* packs/GoogleDrive: added context path for GoogleDrive modify lables



* packs/GoogleDrive: added context path for GoogleDrive get file labels



* packs/GoogleDrive: added context path for GoogleDrive get labels



* packs/GoogleDrive: format file and fix test



* update readme

* update docker

* packs/reco: fix test



---------

Signed-off-by: Gal Nakash <gal@recolabs.ai>
Co-authored-by: GalNakash-RecoLabs <71227802+GalNakash-RecoLabs@users.noreply.github.com>
Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com>
Co-authored-by: ostolero <ostolero@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner post-demo Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants