-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packs/GoogleDrive: add modify labels command #28962
packs/GoogleDrive: add modify labels command #28962
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ostolero will know the proposed changes are ready to be reviewed. |
Add a command to modify labels in google drive Signed-off-by: Gal Nakash <gal@recolabs.ai>
Generate docs based on yaml Signed-off-by: Gal Nakash <gal@recolabs.ai>
0310be1
to
12efe71
Compare
Get labels command to get all labels in google drive Signed-off-by: Gal Nakash <gal@recolabs.ai>
2938e86
to
e61fcb1
Compare
Add command to get labels attached to file Signed-off-by: Gal Nakash <gal@recolabs.ai>
e61fcb1
to
3220714
Compare
Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
PR is ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Gal, great work!
Everything is really according to out standard and looks great, just a few points-
- see my comment regarding adding the logger decorator.
- There are 2 validation failures in the build, the first one is regarding the use of demisto.log (see comment). the second is regarding the use of demisto.results in main. this is not part of your code but if you can change that line to simply
return
that would be greatly appreciated :) - You should add another unit test for the coverage test to pass.
Let me you know if you need any help, I've reached out through slack to schedule a demo :)
Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com>
2ec0c91
to
431d3ae
Compare
Return result instead of return Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
9af51f0
to
42c52f4
Compare
Thank you Gal for a great demo! |
Signed-off-by: Gal Nakash <gal@recolabs.ai>
42c52f4
to
98eadc4
Compare
Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
Signed-off-by: Gal Nakash <gal@recolabs.ai>
f7af938
to
3775cfc
Compare
The context is approved by @melamedbn , need to fix the last validation failures |
Signed-off-by: Gal Nakash <gal@recolabs.ai>
5b261bb
to
52f7274
Compare
@ostolero anything from my side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great!
Hi Gal ,I approved as all the changes are done :) merging this and when the internal pr passes validations we can merge to master. I'll update over Slack when this is expected to show in the marketplace for the client. |
* packs/GoogleDrive: add modify labels command Add a command to modify labels in google drive * packs/GoogleDrive: add modify labels command readme Generate docs based on yaml * packs/GoogleDrive: add get labels command Get labels command to get all labels in google drive * packs/GoogleDrive: get-file-labels command Add command to get labels attached to file * packs/GoogleDrive: update version 1.2.40 * packs/GoogleDrive: update release notes * Update Packs/GoogleDrive/Integrations/GoogleDrive/GoogleDrive.py * packs/GoogleDrive: fix return value Return result instead of return * packs/GoogleDrive: add a test for list labels * packs/GoogleDrive: add a test for modify label * packs/GoogleDrive: rename test files * packs/GoogleDrive: added context path for GoogleDrive modify lables * packs/GoogleDrive: added context path for GoogleDrive get file labels * packs/GoogleDrive: added context path for GoogleDrive get labels * packs/GoogleDrive: format file and fix test * update readme * update docker * packs/reco: fix test --------- Signed-off-by: Gal Nakash <gal@recolabs.ai> Co-authored-by: GalNakash-RecoLabs <71227802+GalNakash-RecoLabs@users.noreply.github.com> Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com> Co-authored-by: ostolero <ostolero@paloaltonetworks.com>
…#29125) * packs/GoogleDrive: add modify labels command Add a command to modify labels in google drive * packs/GoogleDrive: add modify labels command readme Generate docs based on yaml * packs/GoogleDrive: add get labels command Get labels command to get all labels in google drive * packs/GoogleDrive: get-file-labels command Add command to get labels attached to file * packs/GoogleDrive: update version 1.2.40 * packs/GoogleDrive: update release notes * Update Packs/GoogleDrive/Integrations/GoogleDrive/GoogleDrive.py * packs/GoogleDrive: fix return value Return result instead of return * packs/GoogleDrive: add a test for list labels * packs/GoogleDrive: add a test for modify label * packs/GoogleDrive: rename test files * packs/GoogleDrive: added context path for GoogleDrive modify lables * packs/GoogleDrive: added context path for GoogleDrive get file labels * packs/GoogleDrive: added context path for GoogleDrive get labels * packs/GoogleDrive: format file and fix test * update readme * update docker * packs/reco: fix test --------- Signed-off-by: Gal Nakash <gal@recolabs.ai> Co-authored-by: GalNakash-RecoLabs <71227802+GalNakash-RecoLabs@users.noreply.github.com> Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com> Co-authored-by: ostolero <ostolero@paloaltonetworks.com>
Add a command to modify labels in google drive
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have