Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Poetry] boto3-stubs #29132

Merged
merged 6 commits into from
Aug 23, 2023
Merged

[Poetry] boto3-stubs #29132

merged 6 commits into from
Aug 23, 2023

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Aug 22, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added 20 boto3-stubs[package_name] packages to pyproject.toml,
in the [tool.poetry.group.typing.dependencies] section.

With boto3-stubs, the AWS client will be able to use validate they boto3 types with mypy. In addition, VS Code and PyCharm will be able to autocomplete.

# S3Client usage example

from boto3.session import Session

from mypy_boto3_s3.client import S3Client

def get_client() -> S3Client:
    return Session().client("s3")
  1. dynamodb
  2. sagemaker-runtime
  3. ssm
  4. wafv2
  5. accessanalyzer
  6. acm
  7. athena
  8. cloudtrail
  9. logs
  10. ec2
  11. guardduty
  12. iam
  13. lambda
  14. network-firewall
  15. route53
  16. S3
  17. secretsmanager
  18. securityhub
  19. Sns
  20. sqs

Must have

  • Tests
  • Documentation

@shmuel44 shmuel44 requested review from dorschw and ilaner August 22, 2023 11:29
pyproject.toml Outdated Show resolved Hide resolved
@shmuel44 shmuel44 requested a review from dorschw August 22, 2023 15:13
@dorschw dorschw marked this pull request as ready for review August 23, 2023 07:27
@shmuel44 shmuel44 self-assigned this Aug 23, 2023
@shmuel44 shmuel44 merged commit 4cd6371 into master Aug 23, 2023
@shmuel44 shmuel44 deleted the sk_poetry_aws_typing branch August 23, 2023 09:22
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* added 20 package to typing group

* cr

* spacing

* reorder

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants