Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildfire Reports - Reverted the content patch #29155

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

ShacharKidor
Copy link
Contributor

@ShacharKidor ShacharKidor commented Aug 23, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

relates: CRTX-77146.

Description

While working on the above-mentioned issue, I opened this PR - pull/25002 which includes a content patch for handling xsoar ng version 8.1.0.
As described in the issue, the server team fixed their issue and we can now classify XSAOR NG machines as XSOAR machines, by using the get_demisto_version().get('platform') only.
BA5DB4CD-C659-44FA-AAAB-744E355B30EF

In this PR I'm reverting the content patch.

Must have

  • Tests
  • Documentation

@ShahafBenYakir ShahafBenYakir marked this pull request as ready for review August 24, 2023 09:23
@ShacharKidor ShacharKidor merged commit dd4b651 into master Aug 24, 2023
@ShacharKidor ShacharKidor deleted the revert_wildfilre_patch branch August 24, 2023 09:36
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* Reverted the patch

* Updated the docker image tag

* Pre-commit fixes

* Added RN file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants