Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MicrosoftApiModule] Revert of PR 29035 #29173

Merged
merged 3 commits into from
Aug 23, 2023
Merged

[MicrosoftApiModule] Revert of PR 29035 #29173

merged 3 commits into from
Aug 23, 2023

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Aug 23, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Revert changes made in #29035.

@mmhw mmhw requested a review from michal-dagan as a code owner August 23, 2023 14:16
@mmhw mmhw requested a review from bziser August 23, 2023 14:17
bziser
bziser approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@mmhw mmhw added the ForceMerge Forcing the merge of the PR despite the build status label Aug 23, 2023
@mmhw
Copy link
Contributor Author

mmhw commented Aug 23, 2023

Reason for force merge:
Lint fail on:
Message: "[red]Unit-tests for 'Packs/ApiModules/Scripts/MicrosoftApiModule/MicrosoftApiModule.py' must reach a coverage of at least 68.51% (currently: 65.75%).[/red]"

@DeanArbel DeanArbel merged commit a0c2258 into master Aug 23, 2023
@DeanArbel DeanArbel deleted the MW/MicrosoftApiModule/Revert_auth_code_reconfigurations branch August 23, 2023 17:41
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
@mmhw @xsoar-bot
[MicrosoftApiModule] Revert of PR 29035 (demisto#29173)
2e0e69f 
* Revert the 7839428 commit

* Update RN

* Update RN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michal-dagan michal-dagan michal-dagan approved these changes

@bziser bziser bziser approved these changes

Assignees
No one assigned
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmhw @bziser @michal-dagan @DeanArbel