Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit check-json] Align the entire repo with check-json #29403

Merged
merged 14 commits into from
Sep 7, 2023
Merged

[pre-commit check-json] Align the entire repo with check-json #29403

merged 14 commits into from
Sep 7, 2023

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Sep 3, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Related: link to the issue

Description

In order to run pre-commit on our entire repo, it is necessary to fix certain files that fail the check-json hook.

@mmhw mmhw requested a review from bziser September 3, 2023 11:34
@mmhw mmhw self-assigned this Sep 3, 2023
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Your contributed RiskIQDigitalFootprint pack has been modified on files:

Packs/RiskIQDigitalFootprint/Integrations/RiskIQDigitalFootprint/test_data/get_asset_ip_address_resp.json
Packs/RiskIQDigitalFootprint/Integrations/RiskIQDigitalFootprint/test_data/get_asset_page_resp.json
Please review the changes here

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Your contributed CofenseIntelligenceV2 pack has been modified on files:

Packs/CofenseIntelligenceV2/Integrations/CofenseIntelligenceV2/test_data/test_threats.json
Please review the changes here

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Your contributed AbnormalSecurity pack has been modified on files:

Packs/AbnormalSecurity/secrets_white_list.json
Please review the changes here

bziser
bziser reviewed Sep 4, 2023
View reviewed changes
Packs/CortexXDR/ReleaseNotes/5_1_3.md Outdated Show resolved Hide resolved
Packs/DuoAdminApi/ReleaseNotes/4_0_9.md Outdated Show resolved Hide resolved
Packs/PrismaSaasSecurity/ReleaseNotes/2_0_25.md Outdated Show resolved Hide resolved
Packs/epo/ReleaseNotes/2_0_25.md Outdated Show resolved Hide resolved
mmhw and others added 2 commits September 4, 2023 12:34
@mmhw @bziser
Apply suggestions from code review
d59f5b9 
Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
@mmhw
Merge branch 'master' into MW/pre-commit/CIAC-7058/Align_the_entire_r…
bcdbde1 
…epo_with_check-json
@mmhw mmhw requested a review from bziser September 4, 2023 09:34
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • PrismaSaasSecurity pack version was bumped to 2.0.26.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • PrismaSaasSecurity pack version was bumped to 2.0.27.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • epo pack version was bumped to 2.0.26.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 5.1.4.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@mmhw mmhw added the ForceMerge Forcing the merge of the PR despite the build status label Sep 6, 2023
@mmhw
Copy link
Contributor Author

mmhw commented Sep 6, 2023

Reason for force merge:
No test for Modeling Rules

$ ./Tests/scripts/test_modeling_rules.sh || EXIT_CODE=$?
Testing Modeling Rules - Results will be saved to /builds/xsoar/content/artifacts/marketplacev2/modeling_rules_results.xml
[2023-09-05 18:02:17,562] [INFO] Log file location: /builds/xsoar/content/artifacts/marketplacev2/logs/demisto_sdk_debug.log
[2023-09-05 18:02:17,566] [INFO] You are using demisto-sdk 1.20.1.
[2023-09-05 18:02:17,567] [INFO] Modeling Rules directories to test: [PosixPath('/builds/xsoar/content/Packs/DuoAdminApi/ModelingRules/DuoModelingRule'), PosixPath('/builds/xsoar/content/Packs/epo/ModelingRules/McafeeEpoModelingRules'), PosixPath('/builds/xsoar/content/Packs/PrismaSaasSecurity/ModelingRules/SaasSecurityEventCollector_1_3')]
[2023-09-05 18:02:17,568] [INFO] <<<< Test Modeling Rule: Packs/DuoAdminApi/ModelingRules/DuoModelingRule >>>>
[2023-09-05 18:02:17,573] [WARNING] No test data file found for Packs/DuoAdminApi/ModelingRules/DuoModelingRule
[2023-09-05 18:02:17,574] [ERROR] Please create a test data file for Packs/DuoAdminApi/ModelingRules/DuoModelingRule and then rerun
[2023-09-05 18:02:17,574] [ERROR] Error testing modeling rule Packs/DuoAdminApi/ModelingRules/DuoModelingRule
demisto-sdk modeling-rules test Packs/DuoAdminApi/ModelingRules/DuoModelingRule
[2023-09-05 18:02:17,574] [INFO] <<<< Test Modeling Rule: Packs/epo/ModelingRules/McafeeEpoModelingRules >>>>
[2023-09-05 18:02:17,577] [WARNING] No test data file found for Packs/epo/ModelingRules/McafeeEpoModelingRules
[2023-09-05 18:02:17,577] [ERROR] Please create a test data file for Packs/epo/ModelingRules/McafeeEpoModelingRules and then rerun
[2023-09-05 18:02:17,577] [ERROR] Error testing modeling rule Packs/epo/ModelingRules/McafeeEpoModelingRules
demisto-sdk modeling-rules test Packs/epo/ModelingRules/McafeeEpoModelingRules
[2023-09-05 18:02:17,577] [INFO] <<<< Test Modeling Rule: Packs/PrismaSaasSecurity/ModelingRules/SaasSecurityEventCollector_1_3 >>>>
[2023-09-05 18:02:17,580] [WARNING] No test data file found for Packs/PrismaSaasSecurity/ModelingRules/SaasSecurityEventCollector_1_3
[2023-09-05 18:02:17,580] [ERROR] Please create a test data file for Packs/PrismaSaasSecurity/ModelingRules/SaasSecurityEventCollector_1_3 and then rerun
[2023-09-05 18:02:17,580] [ERROR] Error testing modeling rule Packs/PrismaSaasSecurity/ModelingRules/SaasSecurityEventCollector_1_3
demisto-sdk modeling-rules test Packs/PrismaSaasSecurity/ModelingRules/SaasSecurityEventCollector_1_3
$ section_end "Test Modeling Rules"
[2023-09-05T18:02:17.934] section end

@eepstain
Copy link
Contributor

eepstain commented Sep 6, 2023 •
edited
Loading

@mmhw
Please run a Bypass installation for those packs on an XSIAM tenant with a Stable version.

@mmhw
Copy link
Contributor Author

mmhw commented Sep 7, 2023 •
edited
Loading

@mmhw Please run a Bypass installation for those packs on an XSIAM tenant with a Stable version.

Done successfully by @cweltPA.

@DeanArbel DeanArbel merged commit 9dfe7b8 into master Sep 7, 2023
@DeanArbel DeanArbel deleted the MW/pre-commit/CIAC-7058/Align_the_entire_repo_with_check-json branch September 7, 2023 10:09
moishce pushed a commit that referenced this pull request Sep 14, 2023
@mmhw @bziser @moishce
[pre-commit check-json] Align the entire repo with check-json (#29403)
e98d82c 
* Align the entire repo with check-json

* Add RN

* Recovery of the secrets_white_list.json file

* Apply suggestions from code review

Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>

* Bump pack from version PrismaSaasSecurity to 2.0.26.

* Bump pack from version PrismaSaasSecurity to 2.0.27.

* Bump pack from version epo to 2.0.26.

* Bump pack from version CortexXDR to 5.1.4.

---------

Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
@mmhw @bziser @xsoar-bot
[pre-commit check-json] Align the entire repo with check-json (demist…
a008692 
…o#29403)

* Align the entire repo with check-json

* Add RN

* Recovery of the secrets_white_list.json file

* Apply suggestions from code review

Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>

* Bump pack from version PrismaSaasSecurity to 2.0.26.

* Bump pack from version PrismaSaasSecurity to 2.0.27.

* Bump pack from version epo to 2.0.26.

* Bump pack from version CortexXDR to 5.1.4.

---------

Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
@mmhw @bziser @moishce
[pre-commit check-json] Align the entire repo with check-json (#29403)
1bef282 
* Align the entire repo with check-json

* Add RN

* Recovery of the secrets_white_list.json file

* Apply suggestions from code review

Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>

* Bump pack from version PrismaSaasSecurity to 2.0.26.

* Bump pack from version PrismaSaasSecurity to 2.0.27.

* Bump pack from version epo to 2.0.26.

* Bump pack from version CortexXDR to 5.1.4.

---------

Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bziser bziser bziser approved these changes

Assignees

@mmhw mmhw

Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmhw @content-bot @eepstain @bziser @DeanArbel