Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servicenow api fix #29433

Merged
merged 11 commits into from
Sep 6, 2023
Merged

Servicenow api fix #29433

merged 11 commits into from
Sep 6, 2023

Conversation

Shellyber
Copy link
Contributor

@Shellyber Shellyber commented Sep 4, 2023

Status

  • Ready

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-27758

Description

  • Fixed an issue when using the v2 API version the mirror-in and get_attachemtns would fail, since it is not supported in this version

image

@Shellyber Shellyber requested a review from dantavori September 4, 2023 11:40
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • ServiceNow pack version was bumped to 2.5.40.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a disclaimer to the description of the command so it would also appear in the integration README explaining that this command will always use v1 as it is not supported in v2.

# Conflicts:
#	Packs/ServiceNow/ReleaseNotes/2_5_39.md
…now-api-fix

# Conflicts:
#	Packs/ServiceNow/ReleaseNotes/2_5_40.md
@Shellyber Shellyber merged commit bfe715f into master Sep 6, 2023
@Shellyber Shellyber deleted the servicenow-api-fix branch September 6, 2023 11:22
moishce pushed a commit that referenced this pull request Sep 14, 2023
* Fixed an issue with api version v2 in mirror in

* Added release notes

* Bump pack from version ServiceNow to 2.5.40.

* Update docs

* Fixed test

* Fixed DS108

---------

Co-authored-by: Content Bot <bot@demisto.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* Fixed an issue with api version v2 in mirror in

* Added release notes

* Bump pack from version ServiceNow to 2.5.40.

* Update docs

* Fixed test

* Fixed DS108

---------

Co-authored-by: Content Bot <bot@demisto.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* Fixed an issue with api version v2 in mirror in

* Added release notes

* Bump pack from version ServiceNow to 2.5.40.

* Update docs

* Fixed test

* Fixed DS108

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants