Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zscaler] Add URLs to Retaining Parent Category #35844

Merged
merged 12 commits into from
Aug 28, 2024
Merged

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Aug 12, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Added support to the zscaler-category-add-url and zscaler-category-add-ip commands to display retaining-parent-category addresses in the readable output.
  • Added support for the RetainingParentCategoryURL key in the readable and context outputs of the zscaler-get-categories command.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Aug 12, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Zscaler/Integrations/Zscaler
   Zscaler.py62017372%17, 78, 84, 164, 178–179, 183–184, 207–208, 212, 226–234, 241–242, 244–248, 251–258, 265–266, 268–270, 272–278, 282–283, 285–287, 290–293, 296, 298, 301–306, 312–313, 315–317, 319–325, 329–330, 332–334, 337–340, 343, 345, 348–353, 399, 409–415, 423, 425, 473, 522, 532, 535, 538–539, 541, 592, 603, 614, 631, 636, 652, 658–660, 671, 686, 710, 712, 759, 761, 795–797, 799–801, 811, 821–822, 825, 828, 831, 840–841, 846, 857, 861, 863–864, 877–878, 904–905, 913, 921, 929, 937, 955, 965, 983, 993, 1026, 1112–1113, 1130, 1136, 1142–1144, 1149, 1152, 1157, 1160, 1166, 1172, 1174, 1180, 1245
TOTAL62017372% 

Tests Skipped Failures Errors Time
168 0 💤 0 ❌ 0 🔥 8.790s ⏱️

@michal-dagan michal-dagan marked this pull request as ready for review August 12, 2024 15:06
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@michal-dagan michal-dagan merged commit ed09e1d into master Aug 28, 2024
22 checks passed
@michal-dagan michal-dagan deleted the xsup-zscaler-update branch August 28, 2024 08:00
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* update

* update

* fix test

* fix

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants