Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] - EXPANDR-2805 - Update Get VM Details Command #36048

Conversation

BigEasyJ
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

EXPANDR-2805

Description

  • Updated the azure-vm-get-instance-details command to add Tags from a VM instance to alert context.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Aug 27, 2024
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_EXPANDR-2805 August 27, 2024 18:59
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @JasBeilin will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @BigEasyJ, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BigEasyJ , Thank you for the contribution!
Please check my comments and send a demo video so we can move forward.

@BigEasyJ
Copy link
Contributor Author

BigEasyJ commented Sep 3, 2024

@JasBeilin I have updated the PR with your comments, however I don't know what we should demo for this since it just extends an existing field from raw to context. Most of the change in testing.

@thefrieddan1 thefrieddan1 self-requested a review September 3, 2024 08:56
@thefrieddan1 thefrieddan1 self-assigned this Sep 3, 2024
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@thefrieddan1 thefrieddan1 merged commit e53cb0d into demisto:contrib/PaloAltoNetworks_EXPANDR-2805 Sep 3, 2024
15 of 17 checks passed
Copy link

github-actions bot commented Sep 3, 2024

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

thefrieddan1 added a commit that referenced this pull request Sep 3, 2024
…mand (#36118)

* [Marketplace Contribution] -  EXPANDR-2805 - Update Get VM Details Command (#36048)

* Add tags to output of get_vm command

* Update yml and readme

* Add Release Notes

* Code review changes

* bump docker version.

---------

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
…mand (demisto#36118)

* [Marketplace Contribution] -  EXPANDR-2805 - Update Get VM Details Command (demisto#36048)

* Add tags to output of get_vm command

* Update yml and readme

* Add Release Notes

* Code review changes

* bump docker version.

---------

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants