-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marketplace Contribution] - EXPANDR-2805 - Update Get VM Details Command #36048
[Marketplace Contribution] - EXPANDR-2805 - Update Get VM Details Command #36048
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @JasBeilin will know the proposed changes are ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BigEasyJ , Thank you for the contribution!
Please check my comments and send a demo video so we can move forward.
Packs/AzureCompute/Integrations/AzureCompute_v2/test_data/get_vm_command.json
Outdated
Show resolved
Hide resolved
@JasBeilin I have updated the PR with your comments, however I don't know what we should demo for this since it just extends an existing field from raw to context. Most of the change in testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
e53cb0d
into
demisto:contrib/PaloAltoNetworks_EXPANDR-2805
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
…mand (#36118) * [Marketplace Contribution] - EXPANDR-2805 - Update Get VM Details Command (#36048) * Add tags to output of get_vm command * Update yml and readme * Add Release Notes * Code review changes * bump docker version. --------- Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com> Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>
…mand (demisto#36118) * [Marketplace Contribution] - EXPANDR-2805 - Update Get VM Details Command (demisto#36048) * Add tags to output of get_vm command * Update yml and readme * Add Release Notes * Code review changes * bump docker version. --------- Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com> Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
EXPANDR-2805
Description
azure-vm-get-instance-details
command to addTags
from a VM instance to alert context.Must have