[Pack][IdentityRecordedFuture][v2.0.3] #36305
Conversation
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/recordedfuture-dev_identityrecordedfuture_pack_update_2024_09
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @rshunim will know the proposed changes are ready to be reviewed. |
|
Hi @recordedfuture-dev, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
content-bot
added
Partner-Approved
Contribution Form Filled
…update_2024_09' into identityrecordedfuture_pack_update_2024_09
|
Hi @recordedfuture-dev, thanks for your contribution. |
There was a problem hiding this comment.
Hi @recordedfuture-dev, good job!
-
I just wanted to clarify, the reopen argument is now added to the recordedfuture-identity-playbook-alerts-update command when you build a dictionary of json_data and put the arguments in line 40. Do I understand correctly?
(Is this the only place?) -
Please change the value of "server_url" key in the test file line 1268
"server_url": "https://mockurl"
The secret is failed. (Using a clear url is not a secret) -
Please see my comment
Thanks
|
|
||
| ##### Recorded Future Identity | ||
|
|
||
| - Added **reopen** arguments to the **recordedfuture-identity-playbook-alerts-update** command. |
There was a problem hiding this comment.
| - Added **reopen** arguments to the **recordedfuture-identity-playbook-alerts-update** command. | |
| - Added the *reopen* argument to the ***recordedfuture-identity-playbook-alerts-update*** command. |
| attachments = [] | ||
| incident_json = json.loads(incident.get("rawJSON", "{}")) | ||
| if incident_json.get("panel_evidence_summary", {}).get("screenshots"): | ||
| for screenshot_data in incident_json["panel_evidence_summary"][ |
There was a problem hiding this comment.
The code will throw here an exception if incident_json["panel_evidence_summary"]["screenshots"] does not exist. Is that ok for you?
|
@ShirleyDenkberg Please review this pr |
|
@rshunim Doc review completed. |
Identity Recorded Future Pack v2.0.3
Contributing to Cortex XSOAR Content
Status
Description
Integrations
Recorded Future Identity
Must have