chore (refs T34082): add missing Hooks/Selectors & E2E Props. #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-demos
added
review:frontend
salisdemos
requested changes
Aug 17, 2023
Comment on lines
126
to
134
| dataCyEndDate: { | ||
| type: String, | ||
| required: false | ||
| }, | ||
|
|
||
| dataCyStartDate: { | ||
| type: String, | ||
| required: false | ||
| }, |
There was a problem hiding this comment.
for not required fields , we always should use a default
There was a problem hiding this comment.
Done in 3599e2e
salisdemos
requested changes
Aug 17, 2023
| dataCyEndDate: { | ||
| type: String, | ||
| required: false, | ||
| default: '' |
There was a problem hiding this comment.
shouldn't the default be something maningfull like "endDate" ?
There was a problem hiding this comment.
Done in 3a51541, thnx
| dataCyStartDate: { | ||
| type: String, | ||
| required: false, | ||
| default: '' |
There was a problem hiding this comment.
Done in 3a51541, thnx
salisdemos
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://yaits.demos-deutschland.de/T34082
demos-europe/demosplan-ui#443