Fix(DPLAN-12449): dp-obscure tag not being applied #3700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event the cursor from jumping to the end, which occurs if the fullText is updated during the input event
sakutademos
added
the
review:frontend
salisdemos
approved these changes
Sep 20, 2024
…ws) and are expected to be present when fetching entities within the tests. (#3708) * fix(refs DPLAN-11379) the customer got added to the globalContent (news) and are expected to be present when fetching entities within the tests. Throw * style: Apply php-cs-fixer --------- Co-authored-by: Demos-CI <devops-system+github@demos-deutschland.de>
…enerateCustomerCommand (#3680) * fix(refs DPLAN-1917): Add map-params to newly created customers via GenerateCustomerCommand * style: Apply php-cs-fixer * fix(refs DPLAN-1917): Remove leftover unused code snippet * fix(refs DPLAN-1917): alters the command to allow empty strings if really wanted. Changed the user guidance to be more comfortable / understandable. * fix(refs DPLAN-1917): adjust the tests since the command got altered. The tests were skipped with the hint that mysql-client is somehow needed - but the tests work fine at least locally -> removed the skips * fix(refs DPLAN-1917): make use of constants within the customerInterface * style: Apply php-cs-fixer --------- Co-authored-by: Demos-CI <devops-system+github@demos-deutschland.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DPLAN-12449
Description: This PR fixes an issue where the
<dp-obscure>tag was not being applied because thetransformObscureTagfunction was not triggered. This function should be executed with every update action, otherwise, the<dp-obscure>tag will not be transformed as expected.However, executing it with every update action causes another bug, DPLAN-12305 Prevent Cursor from Jumping to End of File. To resolve this, the transformed text should be processed outside the input event to avoid updating the full text directly.
I think it's because
fullTextis av-modelof the editor, and if its value is different from the HTML, it updates the field and causes the cursor to jump. So, we shouldn't updatefullTextdirectly but store it in a different variable. I haven't found a better solution, I tried different approaches... If you have a better idea, feel free to share :)Linked PRs (optional)
fix(Dplan-12449): dp-obscure tag not being applied demosplan-ui#1027
Tests updated/created
Update documentation
Link all relevant tickets
Move the tickets on the board accordingly
Data-Cy attributes added/updated (conventions)