Skip to content

Commit

Permalink
chore (refs T34245): Add missing Hooks/Selectors. (#739)
Browse files Browse the repository at this point in the history
* chore (refs T34245): Add missing Hooks/Selectors.

* chore (refs T34245): add CHANGELOG.md

* Update src/components/DpSelect/DpSelect.vue

Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>

* Update src/components/DpTextArea/DpTextArea.vue

Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>

---------

Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>
  • Loading branch information
ahmad-demos and spiess-demos authored Feb 26, 2024
1 parent d06e56d commit 430e959
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Since v0.0.10, this Changelog is formatted according to the [Common Changelog][c

### Added

- ([#739](https://github.com/demos-europe/demosplan-ui/pull/739)) Add missing data attr for E-2-E Test ([@ahmad-demos](https://github.com/ahmad-demos))
- ([#721](https://github.com/demos-europe/demosplan-ui/pull/721)) Pass the allowEmpty prop to vue-multiselect, which prevents the deselection of values ([@sakutademos](https://github.com/sakutademos))
- ([#718](https://github.com/demos-europe/demosplan-ui/pull/718)) Add missing data attr for E-2-E Test ([@ahmad-demos](https://github.com/ahmad-demos))
- ([#714](https://github.com/demos-europe/demosplan-ui/pull/714)) add csrf token to dpRpc to prevent missing csrf errors ([@muellerdemos](https://github.com/muellerdemos))
Expand Down
3 changes: 2 additions & 1 deletion src/components/DpEditableList/DpEditableList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@

<button
@click.prevent="resetForm"
class="btn btn--secondary u-ml-0_5">
class="btn btn--secondary u-ml-0_5"
data-cy="editableList:abort">
{{ translationKeys.abort }}
</button>
</div>
Expand Down
7 changes: 7 additions & 0 deletions src/components/DpSelect/DpSelect.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}" /><!--
--><select
:id="nameOrId"
:data-cy="dataCy"
:required="required"
:name="name !== '' ? name : false"
class="o-form__control-select"
Expand Down Expand Up @@ -67,6 +68,12 @@ export default {
default: ''
},
dataCy: {
type: String,
required: false,
default: 'selectElement'
},
disabled: {
type: Boolean,
required: false,
Expand Down
7 changes: 7 additions & 0 deletions src/components/DpTextArea/DpTextArea.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
:class="{ 'grow': growToParent, 'h-7': reducedHeight }"
:data-dp-validate-if="dataDpValidateIf"
:data-dp-validate-error-fieldname="dataDpValidateErrorFieldname || label || null"
:data-cy="dataCy"
:disabled="disabled"
:maxlength="maxlength"
v-bind="allowedAttributes"
Expand Down Expand Up @@ -50,6 +51,12 @@ export default {
default: false
},
dataCy: {
type: String,
required: false,
default: 'textAreaElement'
},
disabled: {
type: Boolean,
required: false,
Expand Down

0 comments on commit 430e959

Please sign in to comment.