Skip to content

Commit

Permalink
chore: use default chunkSize value (Infinity) for tus uploads (1031)
Browse files Browse the repository at this point in the history
* chore: use default chunkSize value (Infinity) for tus uploads

* chore: add changelog

* chore: adjust sort order in changelog

* chore: add explanatory comment

 - Important: Only change the default value if you are very sure about the consequences. It is recommended to change the value via setting the chunkSize prop instead of adjusting the default here, which basically allows the upload chunks to be as big as possible.
  • Loading branch information
muellerdemos authored Oct 2, 2024
1 parent fc8d53a commit 6f4a347
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Since v0.0.10, this Changelog is formatted according to the [Common Changelog][c
- ([#1019](https://github.com/demos-europe/demosplan-ui/pull/1019)) DpVideoPlayer: Extend player to support embedded videos ([@gruenbergerdemos](https://github.com/gruenbergerdemos))

### Fixed
- ([#1031](https://github.com/demos-europe/demosplan-ui/pull/1031)) remove max chunkSize on tus uploads ([@muellerdemos](https://github.com/muellerdemos)
- ([#1022](https://github.com/demos-europe/demosplan-ui/pull/1022)) DpEditor: Make EditorContent accessible to the screen readers by adding the 'role' attribute ([@sakutademos](https://github.com/sakutademos)
- ([#1012](https://github.com/demos-europe/demosplan-ui/pull/1012)) Fix breakpoint values in Tailwind config ([@spiess-demos](https://github.com/spiess-demos))

Expand Down
9 changes: 6 additions & 3 deletions src/components/DpUploadFiles/DpUpload.vue
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ export default {
},
/**
* Define chunk size for huge files like PDFs
* Define chunk size for huge files like PDFs.
* Important: Only change the default value if you are very sure about the consequences.
* It is recommended to change the value via setting the chunkSize prop instead of adjusting
* the default here, which basically allows the upload chunks to be as big as possible.
*/
chunkSize: {
type: Number,
Expand All @@ -65,7 +68,7 @@ export default {
},
/**
* Maximum file size in bytes for each individual file
* Maximum file size in bytes for each individual file.
*/
maxFileSize: {
type: Number,
Expand Down Expand Up @@ -216,7 +219,7 @@ export default {
this.uppy.use(Tus, {
endpoint: this.tusEndpoint,
chunkSize: 819200, // 800 KiB
chunkSize: this.chunkSize,
limit: 5,
onAfterResponse: (_req, res) => {
this.currentFileHash = res.getHeader('X-Demosplan-File-Hash')
Expand Down

0 comments on commit 6f4a347

Please sign in to comment.