build(refs T19759): use vueuse/useSortable instead of vuedraggable [vue 3 upgrade] #682 #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Setup for Vue tests * since we are at vue2 , we have to stick to @vue/test-utils@1 * Add some tests
Bumps [dayjs](https://github.com/iamkun/dayjs) from 1.11.7 to 1.11.8. - [Release notes](https://github.com/iamkun/dayjs/releases) - [Changelog](https://github.com/iamkun/dayjs/blob/dev/CHANGELOG.md) - [Commits](iamkun/dayjs@v1.11.7...v1.11.8) --- updated-dependencies: - dependency-name: dayjs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.84.1 to 5.86.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.84.1...v5.86.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: salisdemos <40487461+salisdemos@users.noreply.github.com>
After enabling Tailwind in demosplan-core, we can drop our handcrafted utility classes. As a first step, this PR switches to Tailwind utility classes for all cases where it is possible to do so without further preparation (because the classes are designed the same way and map to static properties). For utility classes that depend on design tokens, and for those that need responsive modifiers, we first have to do some configuration in Tailwind, later on.
Bumps [webpack](https://github.com/webpack/webpack) from 5.86.0 to 5.87.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.86.0...v5.87.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [js-beautify](https://github.com/beautify-web/js-beautify) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/beautify-web/js-beautify/releases) - [Changelog](https://github.com/beautify-web/js-beautify/blob/main/CHANGELOG.md) - [Commits](beautifier/js-beautify@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: js-beautify dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: salisdemos <40487461+salisdemos@users.noreply.github.com>
Bumps [jest-junit](https://github.com/jest-community/jest-junit) from 15.0.0 to 16.0.0. - [Release notes](https://github.com/jest-community/jest-junit/releases) - [Commits](jest-community/jest-junit@v15.0.0...v16.0.0) --- updated-dependencies: - dependency-name: jest-junit dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* bug(refs T33411): Add prop for data-cy on its own
* feat(T33336): add an additional method called "externalApi" to make an external call without default headers * fix(T33336): fix CORS issue: Request header field content-type is not allowed by Access-Control-Allow-Headers in preflight response. To resolve this, the 'Content-Type' header needs to be removed before making the call, as Axios automatically adds it to the request
Co-authored-by: salisdemos <40487461+salisdemos@users.noreply.github.com>
Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>
Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>
This commit adds the "rounded" prop to buttons by using a tailwind utility class. It also adds the arrow-down and arrow-up icons to DpIcon.
Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>
Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>
- in vue 3, boolean attributes are no longer removed when they are set to false, so we need to set them to null instead - see https://v3-migration.vuejs.org/breaking-changes/attribute-coercion
- in order to determine if a list that an element is being dragged to is an allowed target, both the id of the list and a boolean parameter `isAllowedTarget` are now passed to the onMove function - when calling the function in the parent component of DpDraggable, the value of `isAllowedTarget` can be returned, so that the dragging is cancelled (in case `isAllowedTarget` is `false`)
in vue 3, scopedSlots have been removed see https://v3-migration.vuejs.org/breaking-changes/slots-unification.html
by providing the id as an attribute of the html element, we allow accessing it via the properties `to` and `from` of the emitted event `onEnd`
# Conflicts: # babel-jest-transformer.js # package.json # src/components/DpAnonymizeText/DpAnonymizeText.vue # src/components/DpButton/DpButton.vue # src/components/DpButtonRow/DpButtonRow.vue # src/components/DpDataTable/DpDataTable.vue # src/components/DpDataTable/DpTableHeader.vue # src/components/DpDataTable/DpTableRow.vue # src/components/DpDataTableExtended/DpDataTableExtended.vue # src/components/DpDraggable/DpDraggable.vue # src/components/DpEditor/DpLinkModal.vue # src/components/DpEditor/DpUploadModal.vue # src/components/DpInput/DpInput.vue # src/components/DpSplitButton/DpSplitButton.vue # src/components/DpTreeList/DpTreeList.vue # src/components/DpTreeList/DpTreeListNode.vue # yarn.lock
spiess-demos
requested changes
Sep 19, 2024
- I am pretty shure there was a reasoning behind adding prosemirror as peerdependencies, but atm it crashes tiptap. - I think when testng that with addons the challenge will reappear
spiess-demos
requested changes
Sep 30, 2024
spiess-demos
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://yaits.demos-deutschland.de/T35522
vuedraggablethat works with vue 3, we are switching tovueuse/useSortable(see https://vueuse.org/integrations/useSortable/)https://github.com/demos-europe/demosplan-ui/pull/682/files Closed when I deleted i_vue_integration, I didn'T know that this would happen, so I hat to recreate the PR