feat(refs T31492): refactor editor #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want any business logic here, so it is moved to demosplan.
They aren't used anymore. All occurrences were replaced with toolbarItems.
Deprecated props were removed and can't be assigned in the toolbar.
spiess-demos
requested changes
Mar 1, 2023
There is no harm in always using this extension, so we don't need a prop here.
# Conflicts: # CHANGELOG.md
gruenbergerdemos
added a commit
that referenced
this pull request
Mar 20, 2023
With #104 DpBoilerplate was moved to core. This file was accidentally just emptied instead of deleted.
Merged
gruenbergerdemos
added a commit
that referenced
this pull request
Mar 20, 2023
With #104 DpBoilerplate was moved to core. This file was accidentally just emptied instead of deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://yaits.demos-deutschland.de/T31492
With this PR we want to refactor DpEditor and move all business logic to core. The DpRecommendationModal and DpBoilerPlateModal are moved, replaced with slots and all dependent props etc. are removed.
Furthermore I removed all deprecated props since we don't need them anymore (recommended toolbarItems are used).