Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(refs dplan-12315): Make multiselect validation vue3 compatible #1054

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix(refs dplan-12315): Make multiselect validation vue3 compatible #1054

merged 3 commits into from
Oct 28, 2024

Conversation

salisdemos
Copy link
Contributor

@salisdemos salisdemos commented Oct 16, 2024 •
edited
Loading

our validator targeted the wrong element for vue-muliselect in vue3

@salisdemos salisdemos requested review from gruenbergerdemos and hwiem and removed request for gruenbergerdemos October 16, 2024 15:43
@salisdemos salisdemos self-assigned this Oct 16, 2024
@salisdemos salisdemos added the bug Something isn't working label Oct 16, 2024
sakutademos
sakutademos approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@sakutademos sakutademos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, lgtm

@salisdemos salisdemos merged commit 5dd66e0 into main Oct 28, 2024
1 check passed
@salisdemos salisdemos deleted the f_dplan-12315-fix_multiselect_validation branch October 28, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakutademos sakutademos sakutademos approved these changes

@hwiem hwiem Awaiting requested review from hwiem

Assignees

@salisdemos salisdemos

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salisdemos @sakutademos