bug(refs T33153): Add missing props for multiselect #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruenbergerdemos
changed the title
2 tasks
If these props are not given by the parent, we don't want to give them to vue-multiselect, because otherwise we get empty results
If these props are not given by the parent, we don't want to give them to vue-multiselect, because otherwise we get empty results
| @@ -2,12 +2,22 @@ | |||
| <div> | |||
| <vue-multiselect | |||
| :close-on-select="closeOnSelect" | |||
| v-bind="conditionalProps" | |||
| :data-cy="dataCy" | |||
There was a problem hiding this comment.
I wonder if it would enhance readability + is a recognized pattern to move other prop definitions to v-bind, too. Something like...
Suggested change
| :data-cy="dataCy" | |
| v-bind="{ | |
| ...conditionalProps, | |
| dataCy, | |
| deselectGroupLabel, | |
| deselectLabel, | |
| disabled, | |
| groupLabel, | |
| //... | |
| }" |
However idk if this adds to code quality at all.
There was a problem hiding this comment.
I like it (and other team members seem to do, too). Done in 7d0f4b8
Undefined seems to do the trick.
| tagPlaceholder: { | ||
| type: String, | ||
| required: false, | ||
| default: () => Translator.trans('tag.create') |
There was a problem hiding this comment.
Not a blocker right now (it is merged anyways) but didn't we want to drop Translator in demosplan-ui?
There was a problem hiding this comment.
But we still have no concept how to handle things like that. so unfortunately we have to do it this way until we have a technical solution
graupnerdemos
pushed a commit
that referenced
this pull request
Jun 12, 2024
* bug(refs T33153): Add props for groups to multiselect - Add missing props to wrapper component for vue-multiselect - Add undefined as default for customlabel, because otherwise we get an empty label if the parent doesn't give one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://yaits.demos-deutschland.de/T33153
Add some missing props to wrapper component to pass to vue-multiselect.
custom-labelneeds to haveundefinedas default, because otherwise we get an empty label if the parent didn't give one.