Prepare Tailwind config to be used within demosplan-core #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable preflight (= reset/normalize) - set everything important because preflight and other declarations are rendered within the same file, so we can either include tailwind at first (having arbitrary selectors overriding its utilities), or last (having its preflight declarations override stuff) - add some tweaks where demosplan utility classes do not have their counterparts in tailwind
# Conflicts: # src/components/core/DpDataTable/DpTableRow.vue
1 task
salisdemos
approved these changes
Jun 15, 2023
| extend: {} | ||
| extend: { | ||
| flexShrink: { | ||
| 2: '2' |
There was a problem hiding this comment.
out of curiosity: Why that?
There was a problem hiding this comment.
out of the box, tailwind supports flex-shrink 0 or 1. However in one place in demosplan we use flex-shrink: 2, and this is the official way of extending tailwind utility classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Tailwind config so that it includes "Preflight", the opinionated normalize of Tailwind. So, we can drop normalize in demosplan-core.
Also, it adds
yarn build:cssto the prepack steps, so that a complete tailwind build is always included in the package.Lastly, it changes some util classes to be of the tailwind syntax, in preparation of them being dropped from demosplan-core.