F t34968 add dp bulk edit header to storybook #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiess-demos
requested changes
Nov 1, 2023
Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>
Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>
…ents. - Delete deleteSelection method.
- remove selectedItemsText computed. - Add CHANGELOG. - rename selectAll method in Storybook.
spiess-demos
requested changes
Nov 2, 2023
spiess-demos
previously requested changes
Nov 2, 2023
Co-authored-by: spiess-demos <40452344+spiess-demos@users.noreply.github.com>
in fact, the checkbox above the item checkboxes should select all items only if not all items are checked already. If all items are checked, it should uncheck all items. to stop tslint from complaining about undefined args, (args as any) is used here.
spiess-demos
requested review from
salisdemos
and removed request for
spiess-demos
ahmad-demos
requested review from
salisdemos
and removed request for
salisdemos
salisdemos
requested changes
Nov 2, 2023
salisdemos
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://yaits.demos-deutschland.de/T34968
demos-europe/demosplan-core#2245